Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement GitHub Actions #98

Merged
merged 3 commits into from
Jan 6, 2021
Merged

Implement GitHub Actions #98

merged 3 commits into from
Jan 6, 2021

Conversation

paulo-ferraz-oliveira
Copy link
Contributor

@paulo-ferraz-oliveira paulo-ferraz-oliveira commented Dec 8, 2020

You might also want to reference the "build" status in README.md.

I think you need to "activate" GitHub Actions on master after which I can rebase this for testing.

Closes #97.


Note: I added the 23-branch of OTP to the mix and made latest=23.1.

@paulo-ferraz-oliveira
Copy link
Contributor Author

Hi. Is this OK for merging? Do you want further changes?

@paulo-ferraz-oliveira
Copy link
Contributor Author

Ping.

@andreineculau andreineculau merged commit b614b1b into for-GET:master Jan 6, 2021
@andreineculau
Copy link
Member

Thanks. It was a shit show. Among the highlights:

  • erlang containers default to erl as the entrypoint, need to specify bash
  • they run on debian 9, which has a "too old" git for the "github actions' checkout action" (what a mouthful!) so one needs to install a newer git via backports
  • installing git via backports fails on some old erlang container, disabled manually

one alternative is to drop the erlang containers and use kerl.

another alternative: since github actions installs linuxbrew (homebrew), it is possible to install a specific erlang version via homebrew, but then we need to make a local copy in the repo of the respective homebrew formula e.g. brew install $(pwd)/Formula/erlang-18.3/erlang.rb (it's important to keep the file named erlang.rb!)

I see you've opened at least one other issue offering to port travis to github actions in rebar3_lint. My suggestion is we figure out what's the best course of action in jesse before moving forward.

@paulo-ferraz-oliveira
Copy link
Contributor Author

Yeah, I had some issues here, also: https://github.com/inaka/elvis/pull/559/files, where Git has to be installed, since the plugin does a shallow clone.

@paulo-ferraz-oliveira
Copy link
Contributor Author

one alternative is to drop the erlang containers and use kerl.

What are you trying to achieve by not using the container? Do you have any "very specific" behavior that doesn't otherwise work, as-is? I've ported Travis CI to GitHub Actions in many Erlang repo.s already, and have never had any major issues, except that one with elvis whose tests depend on .git.

@paulo-ferraz-oliveira
Copy link
Contributor Author

There's also this: https://github.com/marketplace/actions/setup-erlang. I don't know if you've seen it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move from Travis CI to GitHub Actions?
2 participants