add runtime_value/runtime_validation validation type re:#29 #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| < Content-Type: application/json | ||
| { | ||
| \"{{type}}\": \"runtime_validation\", | ||
| \"erlang\": \"{not_equal, {\\\"/body/{{runtime_validation}}\\\", false, true}}.\" |
There was a problem hiding this comment.
According to Elvis:
Line 177 is too long: "erlang": "{not_equal, {\"/body/{{runtime_validation}}\", false, true}}.".
andreineculau
force-pushed
the
runtime_validation
branch
2 times, most recently
from
03d4ddb
to
1cfbb56
Compare
|
In general I like the idea. 👍 |
andreineculau
force-pushed
the
runtime_validation
branch
from
1882717
to
add566f
Compare
|
added array of code lines https://github.com/for-GET/katt/pull/33/files#diff-04c6e90faac2675aa89e2176d2eec7d8R108 |
andreineculau
force-pushed
the
runtime_validation
branch
from
add566f
to
eac0bcc
Compare
andreineculau
force-pushed
the
runtime_validation
branch
from
eac0bcc
to
3c5f97e
Compare
|
added also a |
andreineculau
added a commit
that referenced
this pull request
Mar 7, 2016
add runtime_value/runtime_validation validation type re:#29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reflected a bit on #29 and came up with an alternative solution based on validation types
ping @sstrigler @erikgustafson-klarna