make useEffect cleaner with functional programming

forbole · Dec 28, 2021 · 5204edd · 5204edd
1 parent a98d796
commit 5204edd
Showing 1 changed file with 12 additions and 5 deletions.
diff --git a/src/screens/profile_details/hooks.ts b/src/screens/profile_details/hooks.ts
@@ -35,6 +35,16 @@ export const useProfileDetails = () => {
     },
   });
 
+  const shouldShowProfile = () => {
+    const dtagConnections = state.desmosProfile.connections;
+    const dtagConnectionsNetwork = dtagConnections.map((x) => { return x.identifier; });
+    const chainPrefix = chainConfig.prefix.account;
+    const containNetwork = dtagConnectionsNetwork.some((x) => x.startsWith(chainPrefix));
+    if (containNetwork) {
+      return true;
+    }
+  };
+
   useEffect(() => {
     const regex = /^@/;
     const profileDtag = router.query.dtag as string;
@@ -52,12 +62,9 @@ export const useProfileDetails = () => {
 
   useEffect(() => {
     if (state.desmosProfile) {
-      const dtagConnections = state.desmosProfile.connections;
-      const dtagConnectionsNetwork = dtagConnections.map((x) => { return x.identifier; });
-      const chainPrefix = chainConfig.prefix.account;
-      const containNetwork = dtagConnectionsNetwork.some((x) => x.startsWith(chainPrefix));
+      const showProfile = shouldShowProfile();
 
-      if (containNetwork) {
+      if (showProfile) {
         const dtagInput = router.query.dtag as string;
         if ((`@${state.desmosProfile.dtag}` !== dtagInput) && (`@${state.desmosProfile.dtag.toUpperCase()}` === dtagInput.toUpperCase())) {
           router.push({ pathname: `/@${state.desmosProfile.dtag}` }, `/@${state.desmosProfile.dtag}`, { shallow: true });