Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add refetch blocks and transactions fix command #248

Merged
merged 57 commits into from
Dec 15, 2021

Conversation

MonikaCat
Copy link
Contributor

@MonikaCat MonikaCat commented Oct 25, 2021

Description

References #216


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2021

Codecov Report

❗ No coverage uploaded for pull request base (v2/cosmos/stargate@0068193). Click here to learn what that means.
The diff coverage is n/a.

@@                  Coverage Diff                  @@
##             v2/cosmos/stargate     #248   +/-   ##
=====================================================
  Coverage                      ?   50.58%           
=====================================================
  Files                         ?       19           
  Lines                         ?     1870           
  Branches                      ?        0           
=====================================================
  Hits                          ?      946           
  Misses                        ?      796           
  Partials                      ?      128           

@MonikaCat MonikaCat marked this pull request as ready for review November 22, 2021 18:03
database/consensus.go Outdated Show resolved Hide resolved
Copy link
Contributor

@huichiaotsou huichiaotsou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested locally

database/consensus.go Outdated Show resolved Hide resolved
database/staking_delegations.go Outdated Show resolved Hide resolved
modules/consensus/config.go Outdated Show resolved Hide resolved
@MonikaCat MonikaCat mentioned this pull request Dec 7, 2021
16 tasks
database/staking_delegations.go Outdated Show resolved Hide resolved
modules/staking/utils_delegations.go Outdated Show resolved Hide resolved
modules/staking/utils_delegations.go Outdated Show resolved Hide resolved
modules/utils/errors.go Outdated Show resolved Hide resolved
@RiccardoM RiccardoM added the automerge Automatically merge PR once all prerequisites pass label Dec 15, 2021
@mergify mergify bot merged commit 703b6ae into v2/cosmos/stargate Dec 15, 2021
@mergify mergify bot deleted the m/fix-missing-blocks branch December 15, 2021 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge PR once all prerequisites pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants