Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [cheqd] add top_accounts module #510

Merged
merged 55 commits into from
Dec 25, 2022

Conversation

huichiaotsou
Copy link
Contributor

@huichiaotsou huichiaotsou commented Dec 19, 2022

Description

Closes: #XXXX

jira: https://forbole.atlassian.net/browse/BDU-707

can test on cosmoshub where there should be enough transactions

chain:
    bech32_prefix: cosmos
    modules:
        - messages
        - auth
        - top_accounts
node:
    type: remote 
    config:
        rpc:
            client_name: juno
            address: https://rpc.cosmoshub.forbole.com:443 
            max_connections: 25
        grpc:
            address: https://grpc.cosmoshub.forbole.com:443
            insecure: false

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@huichiaotsou huichiaotsou changed the title Aaron/top accounts module feat: [cheqd] top accounts module Dec 19, 2022
@huichiaotsou huichiaotsou changed the base branch from cosmos/v0.44.x to chains/cheqd/mainnet December 19, 2022 15:54
@huichiaotsou huichiaotsou changed the base branch from chains/cheqd/mainnet to cosmos/v0.44.x December 19, 2022 15:55
@huichiaotsou huichiaotsou changed the base branch from cosmos/v0.44.x to chains/cheqd/mainnet December 19, 2022 15:56
@MonikaCat MonikaCat changed the title feat: [cheqd] top accounts module feat: [cheqd] add top_accounts module Dec 21, 2022
huichiaotsou and others added 20 commits December 21, 2022 15:53
Co-authored-by: Magic Cat <37407870+MonikaCat@users.noreply.github.com>
Co-authored-by: Magic Cat <37407870+MonikaCat@users.noreply.github.com>
Co-authored-by: Magic Cat <37407870+MonikaCat@users.noreply.github.com>
Co-authored-by: Magic Cat <37407870+MonikaCat@users.noreply.github.com>
Co-authored-by: Magic Cat <37407870+MonikaCat@users.noreply.github.com>
Co-authored-by: Magic Cat <37407870+MonikaCat@users.noreply.github.com>
Co-authored-by: Magic Cat <37407870+MonikaCat@users.noreply.github.com>
Co-authored-by: Magic Cat <37407870+MonikaCat@users.noreply.github.com>
Co-authored-by: Magic Cat <37407870+MonikaCat@users.noreply.github.com>
Co-authored-by: Magic Cat <37407870+MonikaCat@users.noreply.github.com>
Co-authored-by: Magic Cat <37407870+MonikaCat@users.noreply.github.com>
Co-authored-by: Magic Cat <37407870+MonikaCat@users.noreply.github.com>
Co-authored-by: Magic Cat <37407870+MonikaCat@users.noreply.github.com>
Co-authored-by: Magic Cat <37407870+MonikaCat@users.noreply.github.com>
Co-authored-by: Magic Cat <37407870+MonikaCat@users.noreply.github.com>
Co-authored-by: Magic Cat <37407870+MonikaCat@users.noreply.github.com>
Co-authored-by: Magic Cat <37407870+MonikaCat@users.noreply.github.com>
Co-authored-by: Magic Cat <37407870+MonikaCat@users.noreply.github.com>
Co-authored-by: Magic Cat <37407870+MonikaCat@users.noreply.github.com>
Co-authored-by: Magic Cat <37407870+MonikaCat@users.noreply.github.com>
@huichiaotsou huichiaotsou changed the title feat: [cheqd] add top_accounts module feat: [cheqd] add top_accounts module Dec 21, 2022
Copy link
Contributor

@MonikaCat MonikaCat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@RiccardoM RiccardoM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@mergify mergify bot merged commit 2c75a27 into chains/cheqd/mainnet Dec 25, 2022
@mergify mergify bot deleted the aaron/top_accounts_module branch December 25, 2022 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge PR once all prerequisites pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants