Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [cheqd] remove redelegation from top accounts calculations #580

Conversation

MonikaCat
Copy link
Contributor

@MonikaCat MonikaCat commented May 18, 2023

Description

Closes: #XXXX
BDU-949


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@MonikaCat MonikaCat marked this pull request as ready for review May 18, 2023 12:39
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (chains/cheqd/mainnet@4b6ea5d). Click here to learn what that means.
The diff coverage is n/a.

@@                   Coverage Diff                   @@
##             chains/cheqd/mainnet     #580   +/-   ##
=======================================================
  Coverage                        ?   54.21%           
=======================================================
  Files                           ?       22           
  Lines                           ?     1649           
  Branches                        ?        0           
=======================================================
  Hits                            ?      894           
  Misses                          ?      645           
  Partials                        ?      110           

@MonikaCat MonikaCat merged commit ccb2b6d into chains/cheqd/mainnet May 18, 2023
@MonikaCat MonikaCat deleted the BDU-949-top-account-double-counting-bug-when-redelegating branch May 18, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants