@W-13557285: [Android] Upgrade to Gradle 8.x and AGP 8.x Via RN 0.72.x #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also could you subject of the PR reflect the fact it has a RN upgrade? |
JohnsonEricAtSalesforce
force-pushed
the
feature/w-13557285-gradle-8-react-native-0.72.6
branch
from
cec3c9c
to
4f129dc
Compare
JohnsonEricAtSalesforce
changed the title
JohnsonEricAtSalesforce
force-pushed
the
feature/w-13557285-gradle-8-react-native-0.72.6
branch
from
4f129dc
to
55b9b3e
Compare
JohnsonEricAtSalesforce
force-pushed
the
feature/w-13557285-gradle-8-react-native-0.72.6
branch
from
55b9b3e
to
eacd3c4
Compare
JohnsonEricAtSalesforce
force-pushed
the
feature/w-13557285-gradle-8-react-native-0.72.6
branch
from
eacd3c4
to
6f9f691
Compare
wmathurin
requested changes
Dec 1, 2023
wmathurin
reviewed
Dec 1, 2023
brandonpage
approved these changes
Dec 5, 2023
wmathurin
approved these changes
Dec 13, 2023
…ault Github Repositories)
JohnsonEricAtSalesforce
force-pushed
the
feature/w-13557285-gradle-8-react-native-0.72.6
branch
from
5a47110
to
3e5c65c
Compare
JohnsonEricAtSalesforce
merged commit 0515abc
into
forcedotcom:dev
3 of 5 checks passed
JohnsonEricAtSalesforce
deleted the
feature/w-13557285-gradle-8-react-native-0.72.6
branch
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎸 Ready For Final Review 🥁
Be aware this pull request is one of four related to the React Native 0.72.7, Gradle 8.2 and Android Gradle Plugin 8.2.0 upgrades.
👉🏻 forcedotcom/SalesforceMobileSDK-Android#2492
👉🏻 forcedotcom/SalesforceMobileSDK-CordovaPlugin#631
👉🏻 #345
👉🏻 forcedotcom/SalesforceMobileSDK-Templates#387
This prepares SalesforceMobileSDK-ReactNative for supporting React Native 0.72.7, Gradle 8.2, Android Gradle Plugin 8.2.0 and Android 34 in the other three repositories listed above. Overall, the changes here are relatively small though the platform update has significant impacts to downstream projects.
I tested this primarily by using
forcereactto generate every React Native template I could conceive of. Everything compiled and ran OK for both Android and iOS.