@W-13557285: [Android] Upgrade to Gradle 8.x and AGP 8.x Via RN 0.72.x #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmathurin
reviewed
Nov 15, 2023
wmathurin
reviewed
Nov 15, 2023
wmathurin
reviewed
Nov 15, 2023
wmathurin
reviewed
Nov 15, 2023
JohnsonEricAtSalesforce
changed the title
wmathurin
requested changes
Dec 1, 2023
JohnsonEricAtSalesforce
force-pushed
the
feature/w-13557285-gradle-8-react-native-0.72.6
branch
from
8f2e057
to
27be603
Compare
JohnsonEricAtSalesforce
force-pushed
the
feature/w-13557285-gradle-8-react-native-0.72.6
branch
2 times, most recently
from
baa5719
to
931e86f
Compare
This was referenced Dec 13, 2023
wmathurin
requested changes
Dec 13, 2023
bbirman
reviewed
Dec 13, 2023
…mum iOS Version In ReactNativeTemplate Podfile)
…dle Plugin 8.1.4)
…dard Library 1.9.21)
…age.json To Feature Branches)
….jvm.target.validation.mode` According To RN 0.72 Release Notes In MobileSyncExplorerReactNative)
….jvm.target.validation.mode` According To RN 0.72 Release Notes In ReactNativeDeferredTemplate)
….jvm.target.validation.mode` According To RN 0.72 Release Notes In ReactNativeTemplate)
….jvm.target.validation.mode` According To RN 0.72 Release Notes In ReactNativeTypescriptTemplate)
…ndencies For Testing)
…oid Compile SDK Version For Hybrid App Templates)
… iOS Deployment Target)
…ile `config` To A Global Variable)
…leSyncExplorerReactNative iOS Code Changes)
…pper For MobileSyncExplorerReactNative iOS)
…References To `SFApplication`)
… iOS Deployment Target In All iOS React Native Templates)
…ile `config` To A Global Variable In All iOS React Native Templates)
…Code Changes In All iOS React Native Templates)
…pper For All iOS React Native Templates)
JohnsonEricAtSalesforce
force-pushed
the
feature/w-13557285-gradle-8-react-native-0.72.6
branch
from
7261e74
to
cef1d4d
Compare
…Review Cleanup, Pt. 2)
…roid.defaults.buildfeatures.buildconfig Deprecation)
…ault Github Repository References)
JohnsonEricAtSalesforce
force-pushed
the
feature/w-13557285-gradle-8-react-native-0.72.6
branch
from
4c9ec81
to
0bb565d
Compare
| @@ -55,8 +55,6 @@ | |||
| </intent-filter> | |||
| </activity> | |||
| --> | |||
|
|
|||
| <activity android:name="com.facebook.react.devsupport.DevSettingsActivity" | |||
| android:exported="true" /> | |||
There was a problem hiding this comment.
@brandonpage or @wmathurin - Of the three templates, only this one was producing an inspector warning for this exported activity. Was this needed?
There was a problem hiding this comment.
I'd not have changed it, except I was comparing all three React Native templates at the directory level to be sure I'd synchronized the updates accurately. This was an outlier in the diff that seemed worthy of cleanup.
| @@ -55,6 +55,6 @@ | |||
| </intent-filter> | |||
| </activity> | |||
| --> | |||
| <activity android:name="com.facebook.react.devsupport.DevSettingsActivity" android:exported="true" /> | |||
There was a problem hiding this comment.
@brandonpage and @wmathurin - Here's one more activity export warning.
…l Gradle Workspace)
wmathurin
approved these changes
Dec 14, 2023
bbirman
approved these changes
Dec 14, 2023
JohnsonEricAtSalesforce
deleted the
feature/w-13557285-gradle-8-react-native-0.72.6
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎸 Ready For Final Review 🥁
Be aware this pull request is one of four related to the React Native 0.72.7, Gradle 8.2 and Android Gradle Plugin 8.2.0 upgrades.
👉🏻 forcedotcom/SalesforceMobileSDK-Android#2492
👉🏻 forcedotcom/SalesforceMobileSDK-CordovaPlugin#631
👉🏻 forcedotcom/SalesforceMobileSDK-ReactNative#345
👉🏻 #387
The bulk of the upgrade effort resides here in the templates. There are impacts for every template except the stand-alone iOS templates. The React Native templates also received the heaviest changes, which was according to the official React Native Upgrade Helper tool.
For testing, I was able to use the package tools to build and run as many permutations of the affected templates as I could. Everything seemed to run as expected.
The difference report is quite long, but I was able to read through it line-for-line and make a few cleanup commits. Let me know if anything looks amiss. Thanks for your patience with this bigger than usual set of interrelated upgrades.