Removing auth 'concurrency' checks. #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally, the OAuth plugin was guarding against the idea of concurrent authentication requests, and raising a fatal error if authentication was attempted when a previous authentication was already in progress. Problem is, there could be any number of scenarios where previous authentication did not complete, such as switching to another login host, losing network connectivity before completing authentication, etc. Given that authentication concurrency is not nearly as much of an issue as these other "bad app state" scenarios, the code has been updated to remove the check, and simply clean up any previous authentication that might have been in progress.
|
Looks fine to me. |
tstellanova-sfdc
added a commit
that referenced
this pull request
Apr 10, 2012
Removing auth 'concurrency' checks.
khawkins
added a commit
to khawkins/SalesforceMobileSDK-iOS
that referenced
this pull request
Feb 26, 2014
Merging community into SalesforceMobileSDK repo
mneubrand-sfdc
pushed a commit
to mneubrand-sfdc/SalesforceMobileSDK-iOS
that referenced
this pull request
Feb 6, 2015
https://gus.my.salesforce.com/a07B00000011rvH. Fix crash that sometimes ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally, the OAuth plugin was guarding against the idea of concurrent authentication requests, and raising a fatal error if authentication was attempted when a previous authentication was already in progress. Problem is, there could be any number of scenarios where previous authentication did not complete, such as switching to another login host, losing network connectivity before completing authentication, etc.
Given that authentication concurrency is not nearly as much of an issue as these other "bad app state" scenarios, the code has been updated to remove the check, and simply clean up any previous authentication that might have been in progress.