Add scripts for publishing to VS Code Marketplace #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vazexqi
commented
Jul 21, 2017
| } | ||
|
|
||
| if (/win32/.test(process.platform)) { | ||
| shell.exec(`CertUtil -hashfile ${vsix} SHA256`); |
There was a problem hiding this comment.
I don't actually foresee us using Windows to publish, but this is just in case.
vazexqi
commented
Jul 21, 2017
| @@ -66,7 +66,9 @@ runs but that is how you would check locally first. | |||
|
|
|||
| ## List of Useful commands | |||
|
|
|||
| ### `lerna bootstrap` | |||
| _These commands assume that they are executed from the top-level directory. Internally, they delegate to `lerna` to call them on each npm module in the packages directory._ | |||
There was a problem hiding this comment.
Wrapping each one under npm scripts allows the calling mechanism to be simpler (e.g, since you no longer need to remember which ones to call with --concurrency 1).
vazexqi
commented
Jul 21, 2017
| @@ -23,7 +23,7 @@ | |||
| "compile": "tsc -p ./", | |||
| "lint": "tslint --project .", | |||
| "watch": "tsc -watch -p .", | |||
| "clean": "rm -rf node_modules && rm -rf out", | |||
| "clean": "shx rm -rf node_modules && shx rm -rf out", | |||
There was a problem hiding this comment.
Use shelljs/shx to make the script portable across platforms.
vazexqi
commented
Jul 21, 2017
| @@ -39,6 +38,32 @@ | |||
| "message": 7 | |||
| } | |||
| } | |||
| }, | |||
| { | |||
| "taskName": "Lint", | |||
There was a problem hiding this comment.
Added these tasks so that you can now do Cmd + Shift + P in VS Code, type task<space> and get a list of such task to invoke without going to the command line.
|
Here is a sample SHA256 I didn't want to commit this yet since we haven't actually published a version 0.1.0 to the Marketplace. |
vazexqi
force-pushed
the
nick/publish-with-sha256
branch
from
d392b2b
to
d66a9d0
Compare
added 10 commits
July 21, 2017 13:43
@W-4162004@
Also, reorder some of the commands in publish.js so that they make logical sense together. @W-4162004@
This enables us to publish even if nothing has changed since the last time. Useful for situations where we just want to force an increment in version numbers. See https://www.npmjs.com/package/lerna#--force-publish-packages @W-4162004@
vazexqi
force-pushed
the
nick/publish-with-sha256
branch
from
106e9b1
to
4f5fe51
Compare
docs/publishing.md
Outdated
|
|
||
| This is a guide for publishing to the Visual Studio Code Marketplace. Most | ||
| contributors will not need to worry about publishing. However, it might be | ||
| worthwhile familiaring yourself with the steps in case you need to share the |
docs/publishing.md
Outdated
| it to the Visual Studio Code Marketplace. | ||
|
|
||
| It's **crucial** that you publish the .vsix that you had before so that the | ||
| SHA256 match. If you were to repackage, the SHA256 woudl be different. |
DatGuyJonathan
approved these changes
Jul 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds scripts for publishing to the VS Code Marketplace.
Usually we would just use
vsce publish. However, because of vscode-vsce#191, we need to also generate and publish a SHA 256 of each extension for verification.This PR automates most of that – some steps are left as manual for now until we know what to streamline.
What is not in the scope of this PR?
No integration with travis.yml yet.
What issues does this PR fix or reference?
@W-4162004@