Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment out test failure caused by issue in vscode 1.33.0 and above #1247

Merged
merged 1 commit into from
Apr 9, 2019

Conversation

lcampos
Copy link
Contributor

@lcampos lcampos commented Apr 8, 2019

What does this PR do?

Fixes test failing because of vscode 1.33.0 (microsoft/vscode#71947) that's currently blocking other PRs from getting merged.

What issues does this PR fix or reference?

@W-6028723@

@codecov
Copy link

codecov bot commented Apr 9, 2019

Codecov Report

Merging #1247 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1247   +/-   ##
========================================
  Coverage    71.01%   71.01%           
========================================
  Files          196      196           
  Lines         7397     7397           
  Branches       781      781           
========================================
  Hits          5253     5253           
  Misses        1989     1989           
  Partials       155      155

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c57ecf3...11c628d. Read the comment docs.

@lcampos lcampos merged commit 219cdc9 into develop Apr 9, 2019
@lcampos lcampos deleted the lcampos/test-fix-vscode-1.33 branch April 9, 2019 00:38
@salesforce-cla
Copy link

Thanks for the contribution! Unfortunately we can't verify the commit author(s): Luis Campos <l***@s***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, refresh the status of this Pull Request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants