Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update apex-tmlanguage dependency #1973

Merged
merged 1 commit into from
Feb 13, 2020
Merged

Conversation

lcampos
Copy link
Contributor

@lcampos lcampos commented Feb 12, 2020

What does this PR do?

Updates the apex-tmlanguage dependency to get the latest syntax highlighting updates. Below is a list of updates.

  • SOQL when clause highlighting
  • Switch statements with multiple string clauses
  • JavaDoc support
  • Missing apex class highlighting

What issues does this PR fix or reference?

@W-6532166@, @W-7210864@, @W-5973555@, Issue #1180

Functionality Before

SOQL
Screen Shot 2020-02-12 at 3 28 26 PM

JavaDoc
javadoc-before

Apex keyword
system-class-before

Strings on switch
switch-string-before

Functionality After

SOQL
Screen Shot 2020-02-12 at 3 27 40 PM

JavaDoc
javadoc-after

Apex keyword
system-class-after

Strings on switch
Screen Shot 2020-02-12 at 3 09 17 PM

@codecov
Copy link

codecov bot commented Feb 12, 2020

Codecov Report

Merging #1973 into develop will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1973      +/-   ##
===========================================
- Coverage       75%   74.98%   -0.02%     
===========================================
  Files          228      228              
  Lines         8440     8440              
  Branches       937      937              
===========================================
- Hits          6330     6329       -1     
- Misses        1870     1872       +2     
+ Partials       240      239       -1
Impacted Files Coverage Δ
...code-lwc/src/testSupport/testRunner/testWatcher.ts 80% <0%> (-2.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ae8d48...ef031bf. Read the comment docs.

@sfsholden
Copy link
Contributor

Preview of before and after on 'Strings on switch' look like they are the same.

@lcampos
Copy link
Contributor Author

lcampos commented Feb 13, 2020

Preview of before and after on 'Strings on switch' look like they are the same.

Yeah, I should've probably have the token view for that scenario. If you take a closer look the quotes in the Customer No Show string are white because it is getting incorrectly tokenized.

@lcampos lcampos merged commit 44cb1f4 into develop Feb 13, 2020
@lcampos lcampos deleted the lcampos/update-apex-tmlang branch February 13, 2020 16:56
@sfsholden
Copy link
Contributor

Preview of before and after on 'Strings on switch' look like they are the same.

Yeah, I should've probably have the token view for that scenario. If you take a closer look the quotes in the Customer No Show string are white because it is getting incorrectly tokenized.

Ah, I see that now. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants