Respect commenting for embedded JavaScript and CSS in Visualforce #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Per our discussion, if you approve of this, I will update #199 |
vazexqi
commented
Oct 31, 2017
| @@ -68,7 +68,11 @@ | |||
| { | |||
| "language": "visualforce", | |||
| "scopeName": "text.visualforce.markup", | |||
| "path": "./syntaxes/visualforce.json" | |||
| "path": "./syntaxes/visualforce.json", | |||
| "embeddedLanguages": { | |||
There was a problem hiding this comment.
We only support CSS and JavaScript.
DatGuyJonathan
approved these changes
Oct 31, 2017
Merged
ruthemmanuelle
added a commit
that referenced
this pull request
Oct 31, 2017
chowwinston-zz
deleted the
nick/fix-embedded-css-and-javascript-commenting-in-vf
branch
This was referenced Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Respects the embedded mode inside CSS and JavaScript for Visualforce pages.
What issues does this PR fix or reference?
Resolves #198