-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: implement the workflow to publish beta release for core-bundle #5603
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just a couple of questions/suggestions
A lot of the workflows are missing comments on what these workflows do. Is there any specific reason for that? |
jobs: | ||
create_branch: | ||
name: 'Create Branch' | ||
runs-on: ubuntu-latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like this will be tested only on Ubuntu. Any reason to omit Windows?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
buildAndTest workflow tests linux and windows, this is just for the create branch job
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This job 'create_branch' is only for branch creation. Testing is in the job run_build_and_test and e2e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a nit and looks good! Thanks 🚢
Test https://github.com/mingxuanzhangsfdx/salesforcedx-vscode/actions/runs/9181151538
Co-authored-by: Cristina Cañizales <113132642+CristiCanizales@users.noreply.github.com>
What does this PR do?
Implement the workflow to publish beta release for core-bundle.
The workflow first changes the codebase from the core reference to the core-bundle reference, cuts the release branch from main, and then runs buildAndTest workflow.
If build is successful and unit tests pass, it will trigger the e2e tests against the build.
Then a reviewer is required to publish the beta release to Github, after the reviewer checks the test results and potential smoke testing.
The beta release will be available only in Github release.
Also fixes a typo in e2e test.
What issues does this PR fix or reference?
@W-15635226@
Functionality Before
No such a workflow.
Functionality After
One can trigger the beta release workflow from GHA.