Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: implement the workflow to publish beta release for core-bundle #5603

Merged
merged 6 commits into from
May 21, 2024

Conversation

mingxuanzhangsfdx
Copy link
Member

What does this PR do?

Implement the workflow to publish beta release for core-bundle.
The workflow first changes the codebase from the core reference to the core-bundle reference, cuts the release branch from main, and then runs buildAndTest workflow.

If build is successful and unit tests pass, it will trigger the e2e tests against the build.

Then a reviewer is required to publish the beta release to Github, after the reviewer checks the test results and potential smoke testing.

The beta release will be available only in Github release.

Also fixes a typo in e2e test.

What issues does this PR fix or reference?

@W-15635226@

Functionality Before

No such a workflow.

Functionality After

One can trigger the beta release workflow from GHA.

@mingxuanzhangsfdx mingxuanzhangsfdx requested a review from a team as a code owner May 17, 2024 04:56
Copy link
Contributor

@CristiCanizales CristiCanizales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a couple of questions/suggestions

.github/workflows/e2e.yml Show resolved Hide resolved
scripts/create-release-branch.js Show resolved Hide resolved
.github/workflows/createAndTestBetaReleaseBranch.yml Outdated Show resolved Hide resolved
.github/workflows/createAndTestBetaReleaseBranch.yml Outdated Show resolved Hide resolved
@diyer
Copy link
Collaborator

diyer commented May 17, 2024

A lot of the workflows are missing comments on what these workflows do. Is there any specific reason for that?
For e.g. the information in the PR comments help understand what this particular workflow does. Cant they be added as comments to the yml file?

jobs:
create_branch:
name: 'Create Branch'
runs-on: ubuntu-latest
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like this will be tested only on Ubuntu. Any reason to omit Windows?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

buildAndTest workflow tests linux and windows, this is just for the create branch job

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This job 'create_branch' is only for branch creation. Testing is in the job run_build_and_test and e2e

Copy link
Contributor

@CristiCanizales CristiCanizales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.github/workflows/approveAndPublishBeta.yml Outdated Show resolved Hide resolved
Co-authored-by: Cristina Cañizales <113132642+CristiCanizales@users.noreply.github.com>
@mingxuanzhangsfdx mingxuanzhangsfdx merged commit 6586c4f into develop May 21, 2024
12 checks passed
@mingxuanzhangsfdx mingxuanzhangsfdx deleted the mz/publish-beta-workflow branch May 21, 2024 22:18
@mingxuanzhangsfdx mingxuanzhangsfdx restored the mz/publish-beta-workflow branch May 22, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants