-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: implement the workflow to publish beta release for core-bundle #5603
Merged
Merged
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
9036898
chore: implement workflow to publish beta release
mingxuanzhangsfdx 3b6060e
chore: fix the typo for LWC e2e tests
mingxuanzhangsfdx 0501c61
chore: apply reviewer's suggestion
mingxuanzhangsfdx 1f393e6
chore: refactor publish beta workflow
mingxuanzhangsfdx 22b2953
Merge branch 'develop' into mz/publish-beta-workflow
mingxuanzhangsfdx ffb9f91
Update .github/workflows/approveAndPublishBeta.yml
mingxuanzhangsfdx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,81 @@ | ||
name: Create and Test Beta Release Branch | ||
|
||
on: | ||
workflow_dispatch: | ||
|
||
jobs: | ||
create_branch: | ||
name: 'Create Branch' | ||
runs-on: ubuntu-latest | ||
outputs: | ||
version: ${{ steps.version.outputs.version }} | ||
branch: ${{ steps.branch.outputs.branch }} | ||
result: ${{ steps.result.outputs.result }} | ||
env: | ||
RELEASE_TYPE: ${{ 'beta' }} | ||
mingxuanzhangsfdx marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
steps: | ||
- name: Checkout | ||
uses: actions/checkout@v3 | ||
with: | ||
ref: 'main' | ||
ssh-strict: false | ||
token: ${{ secrets.IDEE_GH_TOKEN }} | ||
- name: Setup Node.js | ||
uses: actions/setup-node@v3 | ||
with: | ||
node-version-file: '.nvmrc' | ||
- uses: ./.github/actions/gitConfig | ||
with: | ||
email: ${{ secrets.IDEE_GH_EMAIL }} | ||
- name: Retrieve Scripts | ||
run: | | ||
git clone https://github.com/forcedotcom/bundle-publish-scripts.git | ||
CristiCanizales marked this conversation as resolved.
Show resolved
Hide resolved
|
||
- name: Update references for Publishing | ||
run: | | ||
node bundle-publish-scripts/scripts/update-references-in-vsce.js | ||
node bundle-publish-scripts/scripts/update-bundle-configs-in-vsce.js | ||
- name: Set NPM at the correct version for Lerna | ||
run: npm install -g npm@9.8.1 | ||
- run: npm install | ||
- run: npm install -g shelljs && npm install -g lerna@5.5.4 | ||
- run: rm -rf ./bundle-publish-scripts | ||
- name: Create and Push the Release Branch | ||
id: create_step | ||
run: | | ||
echo "Creating a beta release from branch main" | ||
node scripts/create-release-branch.js | ||
- id: result | ||
run: echo "result=${{ job.status }}" >> $GITHUB_OUTPUT | ||
- id: version | ||
run: echo "version="$(node -pe "require('./packages/salesforcedx-vscode/package.json').version")"" >> $GITHUB_OUTPUT | ||
- id: branch | ||
run: echo "branch=release/v${{ steps.version.outputs.version }}" >> $GITHUB_OUTPUT | ||
|
||
run_build_and_test: | ||
if: ${{ needs.create_branch.result == 'success' }} # Only run this if the previous job is successful | ||
uses: ./.github/workflows/buildAndTest.yml | ||
name: 'Run Build and Unit Test' | ||
needs: create_branch | ||
secrets: inherit | ||
with: | ||
branch: ${{needs.create_branch.outputs.branch}} | ||
label: ${{needs.create_branch.outputs.version}} | ||
|
||
confirm_publish: | ||
CristiCanizales marked this conversation as resolved.
Show resolved
Hide resolved
|
||
needs: run_build_and_test | ||
environment: publish | ||
runs-on: ubuntu-latest | ||
if: ${{ needs.run_build_and_test.result == 'success' }} # Only run this if the previous job was successful | ||
name: 'Confirm Publish Beta Release' | ||
steps: | ||
- run: echo "Please confirm to publish the beta release" | ||
|
||
run_publish_beta_release: | ||
needs: [confirm_publish, run_build_and_test, create_branch] | ||
if: ${{ needs.confirm_publish.result == 'success' }} | ||
name: 'Publish Beta Release' | ||
uses: ./.github/workflows/publishBetaRelease.yml | ||
with: | ||
branch: ${{needs.create_branch.outputs.branch}} | ||
secrets: inherit |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like this will be tested only on Ubuntu. Any reason to omit Windows?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
buildAndTest workflow tests linux and windows, this is just for the create branch job
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This job 'create_branch' is only for branch creation. Testing is in the job run_build_and_test and e2e