Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partition Morton Code Range Swapped In Dimensions #48

Closed
weshoke opened this issue Nov 11, 2015 · 1 comment
Closed

Partition Morton Code Range Swapped In Dimensions #48

weshoke opened this issue Nov 11, 2015 · 1 comment

Comments

@weshoke
Copy link
Contributor

weshoke commented Nov 11, 2015

Going off of the name of the arguments for morton3D_64_Decode_LUT_shifted

inline void morton3D_64_Decode_LUT_shifted(const uint_fast64_t morton, uint_fast32_t& x, uint_fast32_t& y, uint_fast32_t& z){

Seems that the wrong parts of the AABB limit vectors are being passed in:

morton3D_64_Decode_LUT_shifted(morton_start, p_bbox_grid.min[2], p_bbox_grid.min[1], p_bbox_grid.min[0]);

Shouldn't this be

morton3D_64_Decode_LUT_shifted(morton_start, p_bbox_grid.min[0], p_bbox_grid.min[1], p_bbox_grid.min[2]);

https://github.com/Forceflow/ooc_svo_builder/blob/master/src/svo_builder/voxelizer.cpp#L146

@Forceflow
Copy link
Owner

Not sure - I think I do this because the model already got flipped somewhere in the conversion process, and this is a dirty hack to counter that. I'll change it to your suggestion, and see what the output is in model form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants