Changing the jinqJs repo for various reasons

[mcoakley]

I had an email discussion with @fordth about working on the structure of the jinqJs repo to make it more flexible for testing (including regression testing) as well as adding some build scripts. I've forked the repo to work on the issue I raised ( #21 ) and the fork repo is where I'll be doing the work.

If you are interested in letting me know your thoughts you can reply here or start a ticket within my fork.

Here are my goals:

• restructure the project folders for src and distribution
• implement testing structures to allow easy jinqJs testing for full coverage
  • testing of Node module
  • testing of Angular 1.x service
  • testing of TypeScript typings definition file
• implement a build process using TravisCI
• ensure repo is structured for easy development in a collaborative environment

Once done I'll submit the work done as a PR here.

[mcoakley]

In regard to structure I've removed the .idea and .settings folders as they are for IDE configurations. I added those to be ignored by git (in the .gitignore).

I would like to remove the versions folder as well but I could just exclude that through the .npmignore file so it isn't included in the NPM module. Thoughts?

[fordth]

Yes I agree, the versions folder isn't necessary. I first had it there for
a back reference of changes before I put the project in Git and just
continued updating it, but your correct it's no longer needed.
Thanks

On Saturday, November 5, 2016, Mike Coakley notifications@github.com
wrote:

In regard to structure I've removed the .idea and .settings folders as
they are for IDE configurations. I added those to be ignored by git (in the
.gitignore).

I would like to remove the versions folder as well but I could just
exclude that through the .npmignore file so it isn't included in the NPM
module. Thoughts?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#23 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AJoGANfMqyCRwObFQ9hSEtd5i-m4gAPLks5q7R2NgaJpZM4KqatY
.

[mcoakley]

I would like to remove the jinqjs-unstable.js file. Unstable versions can be handled with git branches. Additionally, I would like to move jinqjs.min.js to a build/dist folder and it would be created as part of the build process. If these are acceptable then I would like to follow a common convention I've noticed of putting the code into a lib folder. So we would have lib/jinqjs.js and no jinq.js variants in the repo root. Of course the package.json/etc would be updated to reflect these changes.

[fordth]

I agree, thanks

On Monday, November 7, 2016, Mike Coakley notifications@github.com wrote:

I would like to remove the jinqjs-unstable.js file. Unstable versions can
be handled with git branches. Additionally, I would like to move
jinqjs.min.js to a build/dist folder and it would be created as part of the
build process. If these are acceptable then I would like to follow a common
convention I've noticed of putting the code into a lib folder. So we would
have lib/jinqjs.js and no jinq.js variants in the repo root. Of course the
package.json/etc would be updated to reflect these changes.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#23 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AJoGAEUTyijq7Ar2iIC14GP4dU7tPz5_ks5q722_gaJpZM4KqatY
.