Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instagram Liquid tag embeds in preview sometimes display a truncated height #3015

Open
omenking opened this issue May 31, 2019 · 7 comments
Open
Labels
area: publishing experience issues related to an authors experience publishing. Tags, series, etc. bug always open for contribution

Comments

@omenking
Copy link
Contributor

Is your feature request related to a problem? Please describe.

I'm thinking DEV.to liquid tags does not work for posts and just shows for entire account?
So here I have a portrait image and its cut off.
Screen Shot 2019-05-31 at 3 00 39 PM

Describe the solution you'd like

I think the liquid tag functionality here needs to be enriched.

Describe alternatives you've considered
.

Additional context

@mariocsee
Copy link
Contributor

Hey @omenking, thanks for reporting this issue! Did you encounter this in the editor preview, unpublished post, or published post?

@omenking
Copy link
Contributor Author

Oh good question. I had attempted this in a comment while in preview.
I did not attempt to post, and I have not tried it within an article.

@Zhao-Andy
Copy link
Contributor

This is a weird bug that in my experience only happens in any preview mode. It should show the full Instagram embed when you submit.

@omenking
Copy link
Contributor Author

omenking commented May 31, 2019

@mariocsee I am a loser. It appears that the preview is not representative of the exact outcome when published.

Screen Shot 2019-05-31 at 3 53 23 PM

So no problem here. I have just assumed the result in preview would be the same as pubished

@omenking
Copy link
Contributor Author

Should we close this ticket? For myself now that I know I can live with this.

@Zhao-Andy
Copy link
Contributor

Let's leave it open since it isn't working as intended.

@Zhao-Andy Zhao-Andy added the bug always open for contribution label May 31, 2019
@Zhao-Andy Zhao-Andy changed the title instagram liquid tags for posts Instagram Liquid tag embeds in preview sometimes display a truncated height May 31, 2019
@jessleenyc jessleenyc added the area: publishing experience issues related to an authors experience publishing. Tags, series, etc. label Aug 8, 2019
@rhymes rhymes removed the future label Jul 1, 2020
@cmgorton cmgorton added this to To do in OSS Rotation: Triage stale issues/pr via automation Nov 30, 2020
@joshpuetz joshpuetz moved this from To do to Keep this issue/pr in OSS Rotation: Triage stale issues/pr Jan 25, 2021
@joshpuetz joshpuetz added the external contributors welcome contribution is welcome! label Jan 25, 2021
@nickytonline nickytonline removed the external contributors welcome contribution is welcome! label Feb 9, 2021
@nickytonline
Copy link
Contributor

Also, just want to mentioned that I've seen this happen in preview mode, but also in the published view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: publishing experience issues related to an authors experience publishing. Tags, series, etc. bug always open for contribution
Projects
No open projects
Development

No branches or pull requests

7 participants