Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub authentication to remove URL query parameters #5899

Closed
vaidehijoshi opened this issue Feb 4, 2020 · 1 comment · Fixed by #6022
Closed

Update GitHub authentication to remove URL query parameters #5899

vaidehijoshi opened this issue Feb 4, 2020 · 1 comment · Fixed by #6022
Labels
area: auth authentication and authorization issues

Comments

@vaidehijoshi
Copy link
Contributor

Describe the bug

While authenticating with GitHub in my local environment, I got an email that alerted me to a deprecation in how we auth with the GitHub API.

As it turns out, we use a query parameter to access the /user endpoint in a few places (for example, when we do something like client = Octokit::Client.new(access_token: token).

This has been deprecated, and GitHub's email to me suggests that we change it to avoid getting email reminders every time we auth with them: "Please use the Authorization HTTP header instead as using the access_token query parameter is deprecated."

We need to go through and update all our uses of the access_token query param, since it is now deprecated. See the related documentation here.

To Reproduce

You should get an email from GitHub (provided you have your ENV vars set) that indicates this deprecation if you auth locally, just like I did!

Expected behavior

Kind of goes without saying, but probably we want our auth flow to be updated 😸

@rhymes
Copy link
Contributor

rhymes commented Feb 4, 2020

I wonder if this has any impact in the integration between Devise and omniauth/omniauth-github, which is largely transparent for us but we use for login

(omniauth-github is an abandoned project: https://github.com/omniauth/omniauth-github)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: auth authentication and authorization issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants