You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We had some unused code for Timber in our config files for development and test.
However, this was completely clobbering Rails' default behavior of logging out to log/development.log and log/test.log. We should allow for logging in these environments in particular, and since we're not using Timber there, we can just revert to using the Rails default debugging log levels.
Add Timber logger to specs that explicitly require it
Restore default Rails.logger in specs using Timber logger
Explicitly use Rails.logger in OmniauthCallbacksController
We seem to have different logger classes leaking into this controller in tests.
I'm not entirely sure why this is/haven't been able to investigate yet, but I do think we should be using the Rails.logger explicitly until we can figure that out.](c7a1bd9) by vaidehijoshi
🛠️ [Ensure user is authenticated before doing onboarding Actions (#5937) * ensure user is authenticated before doing onboarding checks
This is a port of app/jobs/update_main_image_background_job.rb
that works with Sidekiq instead of DelayedJob.
Update all references to UpdateMainImageBackgroundHexJob
This updates all references to UpdateMainImageBackgroundHexJob
so they now call UpdateMainImageBackgroundHexWorker, which works
with Sidekiq instead of DelayedJob.
Add a "blank" option to the dropdown to list of badges on internal/badges route.
Also add some checks to handle if an admin accidentally tries to award a "blank" badge.
Here's the Weekly Digest for thepracticaldev/dev.to:
ISSUES
Last week 131 issues were created.
Of these, 96 issues have been closed and 35 issues are still open.
OPEN ISSUES
💚 #5973 Youtube Link Feature, by oliver-gomes
💚 #5972 Stackbit 'Getting Started' page doesn't scroll on iPad app, by joshpuetz
💚 #5971 Fix indentation in search.rake, by JuanitoFatas
💚 #5970 Strange behavior of article editor when devtools is in use (Firefox/Chrome), by abdellani
💚 #5969 [WIP] 5959_Don't_Allow_Users_To_React_to_Unpublished_Posts, by abdellani
💚 #5967 Running DEV in Docker fails with .ruby-version error, by andrasbacsai
💚 #5965 Nil body_markdown Breaks Article Show Page, by mstruve
💚 #5964 Prevent ActiveRecord::Deadlocked With Circular Article/Collection Updates, by mstruve
💚 #5963 Validate that API article params are a Hash, by atsmith813
💚 #5962 Soft save notification_subscription and then check persisted, by mstruve
💚 #5959 Don't Allow Users To React to Unpublished Posts, by mstruve
💚 #5958 Index Tags to Elasticsearch after they are created, by mstruve
💚 #5957 Validate That API Article Params are Hash, If not return helpful error message, by mstruve
💚 #5955 Optimize bottom_content query, by benhalpern
💚 #5953 Consolidate server side main article feed logic, by joshpuetz
💚 #5951 Handle Missing Chat Channel During Creation, by mstruve
💚 #5950 App JS Content: Refactor of display and removal of unused block, by fredhase
💚 #5947 Catch local authentication attempts and give notice about guides, by benhalpern
💚 #5946 Custom "check installation guide" error messages, by benhalpern
💚 #5945 Allow comments without a commentable to be edited and destroyed, by twinsfan421
💚 #5942 Log in Datadog When Sidekiq Worker Fails for Final Time, by mstruve
💚 #5938 [docs] Add a maintainers document, by jacobherrington
💚 #5934 Published date does not update after unpublish/re-publish, by jennapederson
💚 #5932 Display word Word Count while writing, by b3u
💚 #5929 Removed unused special_sidebar, by lightalloy
💚 #5923 Remove unused images, by citizen428
💚 #5918 Homepage left side bar tags followed, by nickytonline
💚 #5917 Remove unused images, by vaidehijoshi
💚 #5914 Fix uses of
html_safe
in.erb
files, by joshpuetz💚 #5899 Update GitHub authentication to remove URL query parameters, by vaidehijoshi
💚 #5892 [WIP] Campaign settings (fullscreen display, sidebar), by lightalloy
💚 #5890 [WIP] Homepage UI Improvements, by ludwiczakpawel
💚 #5883 Not able to Share, by manoj10101996
💚 #5877 API: Fetching endpoint /api/articles/me sometimes returns CORS error., by emilpriver
💚 #5862 Allow end to end encrypted emails, by abenettt
CLOSED ISSUES
❤️ #5968 replace tag adjustment job with tag adjustment worker, by serenaf
❤️ #5966 I am unable to write a post, by RitikaRS
❤️ #5961 Revert "Update queue_adapter to Sidekiq", by atsmith813
❤️ #5960 Update queue_adapter to Sidekiq, by atsmith813
❤️ #5956 Remove Users::EstimateDefaultLanguageJob & spec, by atsmith813
❤️ #5954 Eager load users when handling chat channel memberships, by mstruve
❤️ #5952 Added template select to the pages admin form, by lightalloy
❤️ #5949 Removing border-box from SheCoded landing page, by ludwiczakpawel
❤️ #5948 Updated DB Prep Documentation with Seed Data Section, by nickytonline
❤️ #5944 Add low-value landing pages to robots.txt disallow, by benhalpern
❤️ #5943 Remove .first query in services/notifications/update to fix dying jobs, by atsmith813
❤️ #5941 Include instructions to set Algolia plan, by jacobherrington
❤️ #5940 Correct startup script and docs, by joshpuetz
❤️ #5939 Setup Elasticsearch indexes during Deploy and Local App Setup, by mstruve
❤️ #5937 Ensure user is authenticated before doing onboarding Actions, by mstruve
❤️ #5936 Refactor API Reactions controller and add specs, by rhymes
❤️ #5935 Fixes the link 'Other tools' in docs (on /getting-started/start-app/), by virajvchavan
❤️ #5933 Fix serialization error with video_thumbnail_url, by rhymes
❤️ #5931 Add various badges to README [skip ci], by rhymes
❤️ #5930 Enable bullet during tests to catch N+1 early (and some cleanups), by rhymes
❤️ #5928 Reading Scroll Progress Bar for Your articles in dev.to, by yashwanth2804
❤️ #5927 Describe the bug, by farzalivand
❤️ #5926 Fix bin/startup to use globally installed foreman, by rhymes
❤️ #5925 Use Node lts/erbium (v12) for Netlify builds, by rhymes
❤️ #5924 Remove extra whitespace from text inputs in Buffer share, by citizen428
❤️ #5922 Fix logging for dev and test environments, by vaidehijoshi
❤️ #5921 Add index to notifications table to optimize query, by atsmith813
❤️ #5920 Log Notification db table size, by mstruve
❤️ #5919 Add Code To Setup the Elasticsearch Tag Index, by mstruve
❤️ #5916 Refactored userData while working on hompage makeover., by nickytonline
❤️ #5915 Remove Notifications::TagAdjustmentNotificationJob & spec, by atsmith813
❤️ #5913 Ignore
html_safe
in erb files, by joshpuetz❤️ #5912 Have counters:update_users use a transaction per user and customizable batch size, by rhymes
❤️ #5911 Remove Articles::UpdateMainImageBackgroundHexJob & spec, by atsmith813
❤️ #5910 Remove HtmlVariantTrialCreateJob & spec, by atsmith813
❤️ #5909 Move Notifications::TagAdjustmentNotificationJob to Sidekiq, by atsmith813
❤️ #5908 Allow broadcasts to be created from internal/broadcasts, by vaidehijoshi
❤️ #5907 Remove Unused ChatChannel Indexing, by mstruve
❤️ #5906 Use simpler messaging for ghost account deletion, by Zhao-Andy
❤️ #5905 Remove Notifications::ModerationNotificationJob & spec, by atsmith813
❤️ #5904 Remove quotes from broadcast options in internal form, by vaidehijoshi
❤️ #5903 Remove Notifications::UpdateJob & spec, by atsmith813
❤️ #5902 Removed isRequired for whole user entity as this is done in component…, by nickytonline
❤️ #5901 Move HtmlVariantTrialCreateJob from background job to inline, by atsmith813
❤️ #5900 Created documenation for Common PropTypes., by nickytonline
❤️ #5898 Remove Articles::ScoreCalcJob and spec, by atsmith813
❤️ #5897 Remove Tags::BustCacheJob and spec, by atsmith813
❤️ #5894 Add comment around previewing with v1 vs. v2 editors, by vaidehijoshi
❤️ #5893 Add user as reactable, by Zhao-Andy
❤️ #5891 Update CONTRIBUTING.md, by Computer-Man497
❤️ #5889 Allow deleting comments if article has already been deleted, by citizen428
❤️ #5888 Move Articles::DetectHumanLanguage from background job to inline, by atsmith813
❤️ #5887 Move user deletion by moderator to worker, by citizen428
❤️ #5886 Hey Team, it's been almost a month that I am unable to add a new post. Could you please help with this?, by scarlett8285
❤️ #5885 Show unpublished articles on your own profile, by rsalunga29
❤️ #5884 Preact/React developer tools documentation., by nickytonline
❤️ #5882 Added tag prop types to common prop types, by nickytonline
❤️ #5881 Adds core team member, by fdoxyz
❤️ #5880 Improve dropdown UX for internal/badges, by vaidehijoshi
❤️ #5879 Move HtmlVariantSuccessesCreate from background job to inline, by atsmith813
❤️ #5878 [WIP] Move HtmlVariantSuccessCreateJob to Sidekiq, by atsmith813
❤️ #5876 Add blank placeholder to "Badges" dropdown in /internal/badges, by michael-tharrington
❤️ #5875 Move Articles::ScoreCalcJob to Sidekiq, by atsmith813
❤️ #5874 Some Proptypes cleanup, by nickytonline
❤️ #5873 Render main image in article preview for v2 editor, by vaidehijoshi
❤️ #5872 Move Articles::DetectHumanLangauageJob to Sidekiq, by atsmith813
❤️ #5871 Hookup Elasticsearch in Travis, by mstruve
❤️ #5870 Move Tags::BustCacheJob to Sidekiq, by atsmith813
❤️ #5869 Remove old BadgeAchievements::SendEmailNotificationJob & spec, by atsmith813
❤️ #5868 Remove old Users::SubscribeToMailchimpNewsletterJob & spec, by atsmith813
❤️ #5867 Remove old Users::ResaveArticlesJob and spec, by atsmith813
❤️ #5866 Add signin=true as a param correctly if the URL already has params, by rhymes
❤️ #5865 Replace the initial migration for strong_migrations gem, by rhymes
❤️ #5864 Properly rename Podcasts::BustCacheWorker spec, by rhymes
❤️ #5863 Add missing sha512 to ES mac docs, by mstruve
❤️ #5861 Bump parallel_tests from 2.30.1 to 2.31.0, by dependabot-preview[bot]
❤️ #5860 Bump kaminari from 1.1.1 to 1.2.0, by dependabot-preview[bot]
❤️ #5859 Bump libhoney from 1.14.2 to 1.14.3, by dependabot-preview[bot]
❤️ #5858 Bump rubocop-rails from 2.4.1 to 2.4.2, by dependabot-preview[bot]
❤️ #5857 Bump simplecov from 0.17.1 to 0.18.1, by dependabot-preview[bot]
❤️ #5856 Bump oj from 3.10.1 to 3.10.2, by dependabot-preview[bot]
❤️ #5855 Bump pry-byebug from 3.7.0 to 3.8.0, by dependabot-preview[bot]
❤️ #5854 Bump doorkeeper from 5.2.3 to 5.3.0, by dependabot-preview[bot]
❤️ #5853 Bump strong_migrations from 0.6.0 to 0.6.1, by dependabot-preview[bot]
❤️ #5852 Bump lint-staged from 10.0.3 to 10.0.7, by dependabot-preview[bot]
❤️ #5851 Bump eslint-plugin-react from 7.18.0 to 7.18.3, by dependabot-preview[bot]
❤️ #5850 Bump eslint-config-prettier from 6.9.0 to 6.10.0, by dependabot-preview[bot]
❤️ #5849 Bump honeybadger-js from 2.0.2 to 2.1.0, by dependabot-preview[bot]
❤️ #5848 Bump @storybook/addon-actions from 3.4.11 to 5.3.10, by dependabot-preview[bot]
❤️ #5846 Bump @storybook/addon-links from 3.4.11 to 5.3.10, by dependabot-preview[bot]
❤️ #5845 Bump jsdom from 15.2.1 to 16.1.0, by dependabot-preview[bot]
❤️ #5844 Bump eslint-plugin-import from 2.20.0 to 2.20.1, by dependabot-preview[bot]
❤️ #5843 Bump @storybook/addons from 3.4.11 to 3.4.12, by dependabot-preview[bot]
❤️ #5842 Upgrade gemoji to support disability emojis, by rhymes
❤️ #5841 Add documentation for ENVied & SiteConfig, by citizen428
❤️ #5840 Add whitespace to internal users edit page, by jacobherrington
LIKED ISSUE
👍 #5840 Add whitespace to internal users edit page, by jacobherrington
It received 👍 x0, 😄 x0, 🎉 x1 and ❤️ x0.
NOISY ISSUE
🔈 #5918 Homepage left side bar tags followed, by nickytonline
It received 8 comments.
PULL REQUESTS
Last week, 133 pull requests were created, updated or merged.
UPDATED PULL REQUEST
Last week, 23 pull requests were updated.
💛 #5969 [WIP] 5959_Don't_Allow_Users_To_React_to_Unpublished_Posts, by abdellani
💛 #5962 Soft save notification_subscription and then check persisted, by mstruve
💛 #5958 Index Tags to Elasticsearch after they are created, by mstruve
💛 #5953 Consolidate server side main article feed logic, by joshpuetz
💛 #5942 Log in Datadog When Sidekiq Worker Fails for Final Time, by mstruve
💛 #5929 Removed unused special_sidebar, by lightalloy
💛 #5923 Remove unused images, by citizen428
💛 #5918 Homepage left side bar tags followed, by nickytonline
💛 #5892 [WIP] Campaign settings (fullscreen display, sidebar), by lightalloy
💛 #5829 Remove hardcoded AWS image urls and download images into assets, by seb1441
💛 #5828 Move edit and delete buttons on chat messages to dropdown menu, by bolariin
💛 #5816 Replace ban/banned with suspend/suspended in user facing text, by rhymes
💛 #5814 Return 404 NotFound error if @moderatable Is Not Found instead of failing with 500, by Zeko369
💛 #5809 Fredhase/codeclimate refactor onboarding initializers 3739, by fredhase
💛 #5804 Mailchimp unsubscribe webhook, by citizen428
💛 #5715 [WIP] fix bug preventing tags of mismatched case from being removed, by sunny-b
💛 #5687 Allow
cover_image
of an article to be removed, by vaidehijoshi💛 #5650 Fredhase/refactor codeclimate initializers 3739, by fredhase
💛 #5582 Change BustReactableCacheJob to BustReactableCacheWorker and move to sidekiq, by luchiago
💛 #5281 [WIP] Upgrade to Ruby 2.7.0, by rhymes
💛 #4973 Use a background job to bust old_username from cache when banishing a user., by anthonyms
💛 #4669 Changed color of err class on highlight snippets while creating a new post, by joaoskr
💛 #4184 Add dropdown menu to listings, by zachdixon
MERGED PULL REQUEST
Last week, 110 pull requests were merged.
💜 #5961 Revert "Update queue_adapter to Sidekiq", by atsmith813
💜 #5960 Update queue_adapter to Sidekiq, by atsmith813
💜 #5956 Remove Users::EstimateDefaultLanguageJob & spec, by atsmith813
💜 #5954 Eager load users when handling chat channel memberships, by mstruve
💜 #5952 Added template select to the pages admin form, by lightalloy
💜 #5949 Removing border-box from SheCoded landing page, by ludwiczakpawel
💜 #5948 Updated DB Prep Documentation with Seed Data Section, by nickytonline
💜 #5944 Add low-value landing pages to robots.txt disallow, by benhalpern
💜 #5943 Remove .first query in services/notifications/update to fix dying jobs, by atsmith813
💜 #5941 Include instructions to set Algolia plan, by jacobherrington
💜 #5940 Correct startup script and docs, by joshpuetz
💜 #5939 Setup Elasticsearch indexes during Deploy and Local App Setup, by mstruve
💜 #5937 Ensure user is authenticated before doing onboarding Actions, by mstruve
💜 #5936 Refactor API Reactions controller and add specs, by rhymes
💜 #5935 Fixes the link 'Other tools' in docs (on /getting-started/start-app/), by virajvchavan
💜 #5933 Fix serialization error with video_thumbnail_url, by rhymes
💜 #5931 Add various badges to README [skip ci], by rhymes
💜 #5930 Enable bullet during tests to catch N+1 early (and some cleanups), by rhymes
💜 #5925 Use Node lts/erbium (v12) for Netlify builds, by rhymes
💜 #5924 Remove extra whitespace from text inputs in Buffer share, by citizen428
💜 #5922 Fix logging for dev and test environments, by vaidehijoshi
💜 #5921 Add index to notifications table to optimize query, by atsmith813
💜 #5920 Log Notification db table size, by mstruve
💜 #5919 Add Code To Setup the Elasticsearch Tag Index, by mstruve
💜 #5916 Refactored userData while working on hompage makeover., by nickytonline
💜 #5915 Remove Notifications::TagAdjustmentNotificationJob & spec, by atsmith813
💜 #5913 Ignore
html_safe
in erb files, by joshpuetz💜 #5912 Have counters:update_users use a transaction per user and customizable batch size, by rhymes
💜 #5911 Remove Articles::UpdateMainImageBackgroundHexJob & spec, by atsmith813
💜 #5910 Remove HtmlVariantTrialCreateJob & spec, by atsmith813
💜 #5909 Move Notifications::TagAdjustmentNotificationJob to Sidekiq, by atsmith813
💜 #5908 Allow broadcasts to be created from internal/broadcasts, by vaidehijoshi
💜 #5907 Remove Unused ChatChannel Indexing, by mstruve
💜 #5906 Use simpler messaging for ghost account deletion, by Zhao-Andy
💜 #5905 Remove Notifications::ModerationNotificationJob & spec, by atsmith813
💜 #5904 Remove quotes from broadcast options in internal form, by vaidehijoshi
💜 #5903 Remove Notifications::UpdateJob & spec, by atsmith813
💜 #5902 Removed isRequired for whole user entity as this is done in component…, by nickytonline
💜 #5901 Move HtmlVariantTrialCreateJob from background job to inline, by atsmith813
💜 #5900 Created documenation for Common PropTypes., by nickytonline
💜 #5898 Remove Articles::ScoreCalcJob and spec, by atsmith813
💜 #5897 Remove Tags::BustCacheJob and spec, by atsmith813
💜 #5894 Add comment around previewing with v1 vs. v2 editors, by vaidehijoshi
💜 #5893 Add user as reactable, by Zhao-Andy
💜 #5891 Update CONTRIBUTING.md, by Computer-Man497
💜 #5889 Allow deleting comments if article has already been deleted, by citizen428
💜 #5888 Move Articles::DetectHumanLanguage from background job to inline, by atsmith813
💜 #5887 Move user deletion by moderator to worker, by citizen428
💜 #5884 Preact/React developer tools documentation., by nickytonline
💜 #5882 Added tag prop types to common prop types, by nickytonline
💜 #5881 Adds core team member, by fdoxyz
💜 #5880 Improve dropdown UX for internal/badges, by vaidehijoshi
💜 #5879 Move HtmlVariantSuccessesCreate from background job to inline, by atsmith813
💜 #5875 Move Articles::ScoreCalcJob to Sidekiq, by atsmith813
💜 #5874 Some Proptypes cleanup, by nickytonline
💜 #5873 Render main image in article preview for v2 editor, by vaidehijoshi
💜 #5871 Hookup Elasticsearch in Travis, by mstruve
💜 #5870 Move Tags::BustCacheJob to Sidekiq, by atsmith813
💜 #5869 Remove old BadgeAchievements::SendEmailNotificationJob & spec, by atsmith813
💜 #5868 Remove old Users::SubscribeToMailchimpNewsletterJob & spec, by atsmith813
💜 #5867 Remove old Users::ResaveArticlesJob and spec, by atsmith813
💜 #5866 Add signin=true as a param correctly if the URL already has params, by rhymes
💜 #5865 Replace the initial migration for strong_migrations gem, by rhymes
💜 #5864 Properly rename Podcasts::BustCacheWorker spec, by rhymes
💜 #5863 Add missing sha512 to ES mac docs, by mstruve
💜 #5861 Bump parallel_tests from 2.30.1 to 2.31.0, by dependabot-preview[bot]
💜 #5860 Bump kaminari from 1.1.1 to 1.2.0, by dependabot-preview[bot]
💜 #5859 Bump libhoney from 1.14.2 to 1.14.3, by dependabot-preview[bot]
💜 #5858 Bump rubocop-rails from 2.4.1 to 2.4.2, by dependabot-preview[bot]
💜 #5856 Bump oj from 3.10.1 to 3.10.2, by dependabot-preview[bot]
💜 #5855 Bump pry-byebug from 3.7.0 to 3.8.0, by dependabot-preview[bot]
💜 #5854 Bump doorkeeper from 5.2.3 to 5.3.0, by dependabot-preview[bot]
💜 #5853 Bump strong_migrations from 0.6.0 to 0.6.1, by dependabot-preview[bot]
💜 #5852 Bump lint-staged from 10.0.3 to 10.0.7, by dependabot-preview[bot]
💜 #5851 Bump eslint-plugin-react from 7.18.0 to 7.18.3, by dependabot-preview[bot]
💜 #5850 Bump eslint-config-prettier from 6.9.0 to 6.10.0, by dependabot-preview[bot]
💜 #5849 Bump honeybadger-js from 2.0.2 to 2.1.0, by dependabot-preview[bot]
💜 #5845 Bump jsdom from 15.2.1 to 16.1.0, by dependabot-preview[bot]
💜 #5844 Bump eslint-plugin-import from 2.20.0 to 2.20.1, by dependabot-preview[bot]
💜 #5843 Bump @storybook/addons from 3.4.11 to 3.4.12, by dependabot-preview[bot]
💜 #5842 Upgrade gemoji to support disability emojis, by rhymes
💜 #5841 Add documentation for ENVied & SiteConfig, by citizen428
💜 #5840 Add whitespace to internal users edit page, by jacobherrington
💜 #5834 Fix typo in ReactionObserver, by Zhao-Andy
💜 #5833 Use cleverer patterns to fetch/iterate AR objects when checking presence, by rhymes
💜 #5826 Fix raising validation if followable already exist(race condition), by gonzar11
💜 #5823 Footer in
shecoded
rendered twice, by abdellani💜 #5822 Update contributor guide with new tag name, by citizen428
💜 #5821 Remove Foreman gem, by citizen428
💜 #5820 Handle Reactions Without Users When Sending Notifications, by abdellani
💜 #5818 Style: update height of speakerdeck tag to be avoid scaling, by deepu105
💜 #5812 chore: add a core team member, by Ridhwana
💜 #5806 Return NotFound error if ChatChannelMembership is not found, by majakomel
💜 #5805 Improve API controllers efficiency by selecting only columns needed for serialization, by rhymes
💜 #5803 Refactor ProfileImage, by seb1441
💜 #5802 Adjust cloning example to use SSH rather than HTTPS, by juliannatetreault
💜 #5798 Fix/events show 404, by Zeko369
💜 #5797 Track stripe errors in Datadog so we can alert on them, by mstruve
💜 #5786 Freeze yarn to 1.21.1, by rhymes
💜 #5784 Remove direct chat channels when banishing user, by citizen428
💜 #5780 One less place you need to bump the ruby version, by swrobel
💜 #5762 Introduce Elasticsearch to DEV env, by mstruve
💜 #5731 Add mod channel automation to tags, by benhalpern
💜 #5721 Add an internal user interface guide, by jacobherrington
💜 #5697 Worker/estimate default language, by maykonmenezes
💜 #5662 Add readonly ApplicationConfig to /internal/config, by citizen428
💜 #5564 Onboarding JS: refactor function out of repetitive blocks, by fredhase
💜 #5443 Move Podcasts::GetEpisodesJob to Sidekiq, by maykonmenezes
💜 #5373 User counters using PostgreSQL JSON, by rhymes
💜 #5345 Migrate update main image background job to sidekiq, by codekatas-magmalabs
COMMITS
Last week there were 110 commits.
🛠️ Revert "Update queue_adapter to Sidekiq (#5960)" (#5961) [deploy] This reverts commit 05ce09b8990abc1b6a758110b8d9214433a43299. by atsmith813
🛠️ Update queue_adapter to Sidekiq (#5960) [deploy] by atsmith813
🛠️ Remove Users::EstimateDefaultLanguageJob & spec (#5956) [deploy] by atsmith813
🛠️ Added template select to the pages admin form (#5952) [deploy] by lightalloy
🛠️ [Handle Reactions Without Users When Sending Notifications (#5820) * Add reaction's owner existence in the database
Add test](faad0b8) by abdellani
🛠️ [Add low-value landing pages to robots.txt disallow (Add low-value landing pages to robots.txt disallow #5944) [deploy] * Add low-value landing pages to robots.txt disallow
Update app/views/pages/robots.text.erb
Update app/views/pages/robots.text.erb](2c07b08) by benhalpern
🛠️ create Users::EstimateDefaultLanguageWorker for Sidekiq (#5697) [deploy] by maykonmenezes
🛠️ Eager load users when handling chat channel memberships (#5954) by mstruve
🛠️ [Remove Unused ChatChannel Indexing (Remove Unused ChatChannel Indexing #5907) [deploy] * remove unused algolia code from chat channel
remove new chat_channel index code and unused methods](e159217) by mstruve
🛠️ [Refactor API Reactions controller and add specs (Refactor API Reactions controller and add specs #5936) * Add specs
Check the object, not the ID
Use permitted params and delete cache only after create
Inherit from ApiController, bail if the reaction user does not exist, fix naming
Remove superflous test](69b04d3) by rhymes
🛠️ removing border-box from shecoded landing page (#5949) by ludwiczakpawel
🛠️ Added a section about increasing seed data. (#5948) by nickytonline
🛠️ [Fix logging for dev and test environments (Fix logging for dev and test environments #5922) * Fix logging for dev and test environments
We had some unused code for Timber in our config files for development and test.
However, this was completely clobbering Rails' default behavior of logging out to log/development.log and log/test.log. We should allow for logging in these environments in particular, and since we're not using Timber there, we can just revert to using the Rails default debugging log levels.
Add Timber logger to specs that explicitly require it
Restore default Rails.logger in specs using Timber logger
Explicitly use Rails.logger in OmniauthCallbacksController
We seem to have different logger classes leaking into this controller in tests.
I'm not entirely sure why this is/haven't been able to investigate yet, but I do think we should be using the Rails.logger explicitly until we can figure that out.](c7a1bd9) by vaidehijoshi
🛠️ [Ensure user is authenticated before doing onboarding Actions (#5937) * ensure user is authenticated before doing onboarding checks
add specs for authenticating users for onboarding updates](bbeb3fc) by mstruve
🛠️ [Enable bullet during tests to catch N+1 early (and some cleanups) (Enable bullet during tests to catch N+1 early (and some cleanups) #5930) [deploy] * Remove unused methods
Small refactorings
Enable bullet in testing mode
Remove unused eager loading for notes
Skip bullet on rolify method
Use .present?
Fix method name](6cd46ae) by rhymes
🛠️ [Setup Elasticsearch indexes during Deploy and Local App Setup (Setup Elasticsearch indexes during Deploy and Local App Setup #5939) * setup Elasticsearch indexes during deploy and local app setup
cleanup previous duplicate sentence
remove more duplicate docs](a13533c) by mstruve
🛠️ Remove .first query on notifications (#5943) by atsmith813
🛠️ Refactor ProfileImage (#5803) by seb1441
🛠️ Fixes the link 'Other tools' in docs (on /getting-started/start-app/) (#5935) * Fixes the link 'Other tools' * Update docs/getting-started/start-app.md Co-Authored-By: rhymes rhymesete@gmail.com Co-authored-by: rhymes rhymesete@gmail.com by virajvchavan
🛠️ [Add various badges to README [skip ci] (Add various badges to README [skip ci] #5931) * Add some badges to the README
Add proper Netlify badge
Add Honeybadger badge](44670e2) by rhymes
🛠️ Include instructions to set Algolia plan (#5941) by jacobherrington
🛠️ Correct startup script and docs (#5940) by joshpuetz
🛠️ Properly rename Podcasts::BustCacheWorker spec (#5864) by rhymes
🛠️ [Add mod channel automation to tags (Add mod channel automation to tags #5731) [deploy] * Add mod channel automation to tags
Change mod_relations to mod_relations_admin
Run migration properly
Make queries consistent and fix test](f3c86c6) by benhalpern
🛠️ Onboarding JS: refactor function out of repetitive blocks (#5564) [deploy] by fredhase
🛠️ Remove extra whitespace from text inputs in Buffer share (#5924) [deploy] by citizen428
🛠️ [Bump doorkeeper from 5.2.3 to 5.3.0 (Bump doorkeeper from 5.2.3 to 5.3.0 #5854) [deploy] Bumps doorkeeper from 5.2.3 to 5.3.0.
Signed-off-by: dependabot-preview[bot] support@dependabot.com](5aa6e26) by dependabot-preview[bot]
🛠️ [Use simpler messaging for ghost account deletion (#5906) * Use simpler messaging for ghost account deletion
Add 'have questions' section
Use same language for confirm destroy page](975a716) by Zhao-Andy
🛠️ [Style: update height of speakerdeck tag to be avoid scaling (Style: update height of speakerdeck tag to be avoid scaling #5818) * style: update height of speackerdeck tag to be avoid scaling
style: remove incorrect padding and margin from speackerdeck tag
add a comment](5194c00) by deepu105
🛠️ Refactored userData while working on hompage makeover. (#5916) [deploy] by nickytonline
🛠️ [Adjust cloning example to use SSH rather than HTTPS (Adjust cloning example to use SSH rather than HTTPS #5802) * Adjust cloning example to use SSH rather than HTTPS
Add SSH example alongside HTTPS example when cloning DEV repo](c9d4dde) by juliannatetreault
🛠️ [Move Podcasts::GetEpisodesJob to Sidekiq (Move Podcasts::GetEpisodesJob to Sidekiq #5443) [deploy] * Refactored Podcast::GetEpisodesJob to sidekiq
fixing specs
removing env keys
Change arguments to Hash
Update specs and add spec for queue
Update references for Hash argument
Add comment to explain parameters of #perform
Co-authored-by: Alex alexandersmith223@gmail.com](01dc81a) by maykonmenezes
🛠️ Use Node lts/erbium (v12) for Netlify builds (#5925) by rhymes
🛠️ Add index to notifications to optimize query (#5921) [deploy] - Index notifications on notifiable_id, notifiable_type, and action by atsmith813
🛠️ Add Code To Setup the Elasticsearch Tag Index (#5919) [deploy] by mstruve
🛠️ Add an internal user interface guide [ci skip] (#5721) [deploy] by jacobherrington
🛠️ Fix serialization error with video_thumbnail_url (#5933) by rhymes
🛠️ log Notification db table size (#5920) [deploy] by mstruve
🛠️ Improve API controllers efficiency by selecting only columns needed for serialization (#5805) [deploy] by rhymes
🛠️ Update CONTRIBUTING.md (#5891) Edited some grammar - Thanks Grammarly! by Computer-Man497
🛠️ Removed isRequired for whole user entity (#5902) This is already done in components that consume these PropTypes by nickytonline
🛠️ Add common tag PropTypes (#5882) by nickytonline
🛠️ Upgrade gemoji to support disability emojis (#5842) by rhymes
🛠️ Created documenation for Common PropTypes. (#5900) by nickytonline
🛠️ Preact/React developer tools documentation. (#5884) by nickytonline
🛠️ Allow deleting comments if article has already been deleted (#5889) [deploy] by citizen428
🛠️ [Bump jsdom from 15.2.1 to 16.1.0 (#5845) [deploy] Bumps jsdom from 15.2.1 to 16.1.0.
Signed-off-by: dependabot-preview[bot] support@dependabot.com](22c6436) by dependabot-preview[bot]
🛠️ Use yarn 1.21.1 (#5786) by rhymes
🛠️ Remove Foreman gem (#5821) by citizen428
🛠️ Adds core team member [ci skip] (#5881) by fdoxyz
🛠️ Remove Notifications::TagAdjustmentNotificationJob (#5915) [deploy] by atsmith813
🛠️ Remove UpdateMainImageBackgroundHexJob & spec (#5911) by atsmith813
🛠️ Remove HtmlVariantTrialCreateJob & spec (#5910) by atsmith813
🛠️ [Move Notifications::TagAdjustmentNotificationJob to Sidekiq (#5909) [deploy] * Create TagAdjustmentNotificationWorker
Create TagAdjustmentNotificationWorker spec
Update references and specs for new worker
Future proof specs](6a10041) by atsmith813
🛠️ Ignore
html_safe
in erb files (#5913) by joshpuetz🛠️ Have counters:update_users use a transaction per user and customizable batch size (#5912) [deploy] by rhymes
🛠️ [Fix raising validation if followable already exist(race condition) (Fix raising validation if followable already exist(race condition) #5826) * Fix raising validation if followable already exist(race condition)
Change Rails Logger for DataDogStatsClient and remove 'begin' keyword in follow method
Co-authored-by: Gonzalo Ricco gonzalo.ricco@leniolabs.com](dd796aa) by gonzar11
🛠️ Return NotFound error if ChatChannelMembership is not found (#5806) by majakomel
🛠️ Move user deletion by moderator to worker (#5887) [deploy] by citizen428
🛠️ Use cleverer patterns to fetch/iterate AR objects when checking presence (#5833) [deploy] by rhymes
🛠️ [Add user as reactable (#5893) * Add user as reactable
Make title method public
Use constants for reactable_type and status](be6aaf7) by Zhao-Andy
🛠️ [Migrate update main image background job to sidekiq (Migrate update main image background job to sidekiq #5345) [deploy] * Add new UpdateMainImageBackgroundHexWorker worker class
This is a port of app/jobs/update_main_image_background_job.rb
that works with Sidekiq instead of DelayedJob.
This updates all references to UpdateMainImageBackgroundHexJob
so they now call UpdateMainImageBackgroundHexWorker, which works
with Sidekiq instead of DelayedJob.
Move method call to after_commit callback
Fix article specs with sidekiq helpers
Co-authored-by: Alex alexandersmith223@gmail.com](bae7ee8) by codekatas-magmalabs
🛠️ Move HtmlVariantTrial#create inline (#5901) [deploy] by atsmith813
🛠️ Remove Notifications::ModerationNotificationJob (#5905) [deploy] by atsmith813
🛠️ Remove Notifications::UpdateJob and spec (#5903) by atsmith813
🛠️ Remove Articles::ScoreCalcJob and spec (#5898) by atsmith813
🛠️ Remove Tags::BustCacheJob and spec (#5897) by atsmith813
🛠️ Allow broadcasts to be created from internal/broadcast (#5908) [deploy] Also raise errors when necessary in all broadcast endpoints.
Clean up tests and add specs for POST /internal/broadcast by vaidehijoshi
🛠️ [Remove direct chat channels when banishing user (#5784) [deploy] * Remove direct chat channels when banishing user
Also remove article's buffer updates
Incorporate PR feedback and make deletion safer](a26ea73) by citizen428
🛠️ Bump eslint-config-prettier from 6.9.0 to 6.10.0 (#5850) by dependabot-preview[bot]
🛠️ Remove quotes from broadcast options in internal form (#5904) [deploy] by vaidehijoshi
🛠️ Bump eslint-plugin-react from 7.18.0 to 7.18.3 (#5851) by dependabot-preview[bot]
🛠️ [Add readonly ApplicationConfig to /internal/config (Add readonly ApplicationConfig to /internal/config #5662) [deploy] * Add readonly ApplicationConfig to /internal/config
Incorporate PR feedback
Remove spurious div](9e6a363) by citizen428
🛠️ Bump kaminari from 1.1.1 to 1.2.0 (#5860) by dependabot-preview[bot]
🛠️ [Move Articles::DetectHumanLanguage from background job to inline (Move Articles::DetectHumanLanguage from background job to inline #5888) [deploy] * Move DetectHumanLanguage inline
Remove old DetectHumanLanguage job and spec
Fix copy/pasta mixup...oopsie!
Update article_spec for inline LanguageDetector](67894aa) by atsmith813
🛠️ Move HtmlVariantSuccessesCreate from job to inline (#5879) [deploy] by atsmith813
🛠️ [Move Articles::ScoreCalcJob to Sidekiq (Move Articles::ScoreCalcJob to Sidekiq #5875) [deploy] * Create Articles::ScoreCalcWorker
Create Articles::ScoreCalcWorker spec
Update references to the new ScoreCalcWorker
Refactoring conditional callbacks and biz logic
🛠️ [Add documentation for ENVied & SiteConfig (Add documentation for ENVied & SiteConfig #5841) * Add documentation for ENVied & SiteConfig
Add images
Fix swapped screenshots and update list](5c74464) by citizen428
🛠️ [Move Tags::BustCacheJob to Sidekiq (Move Tags::BustCacheJob to Sidekiq #5870) [deploy] * Create Tags::BustCacheWorker
Create Tags::BustCacheWorker spec
Update references to new worker](0c42ea2) by atsmith813
🛠️ [Improve dropdown UX for internal/badges (Improve dropdown UX for internal/badges #5880) [deploy] * Improve dropdown UX for internal/badges
Add a "blank" option to the dropdown to list of badges on internal/badges route.
Also add some checks to handle if an admin accidentally tries to award a "blank" badge.
🛠️ Add comment to highlight difference between previewing in v1 and v2 editors (#5894) A follow-up to https://github.com/thepracticaldev/dev.to/pull/5873. by vaidehijoshi
🛠️ Update contributor guide with new tag name (#5822) by citizen428
🛠️ Add signin=true as a param correctly if the URL already has params (#5866) [deploy] by rhymes
🛠️ Hookup Elasticsearch in travis (#5871) by mstruve
🛠️ Cleanup proptypes exports (#5874) by nickytonline
🛠️ Bump oj from 3.10.1 to 3.10.2 (#5856) by dependabot-preview[bot]
🛠️ Remove footer rendering from shecoded.html.erb (#5823) by abdellani
🛠️ Render main image in article preview for v2 editor (#5873) [deploy] Previewing a main image on an article was broken in v2 of the editor :(
We had some tests for this (which I wrote), but the setup for the tests weren't quite right!
This commit fixes the bug, and also refactors and cleans up our tests quite a bit.
Also adds some snapshots for both v1 and v2 editors in a "no image" preview state. by vaidehijoshi
🛠️ Remove BadgeAchievements::SendEmailNotificationJob (#5869) [deploy] by atsmith813
🛠️ Remove old SubscribeToMailchimpNewsletterJob & spec (#5868) by atsmith813
🛠️ Remove old ResaveArticlesJob and spec (#5867) by atsmith813
🛠️ Bump honeybadger-js from 2.0.2 to 2.1.0 (#5849) by dependabot-preview[bot]
🛠️ [Add whitespace to internal users edit page (Add whitespace to internal users edit page #5840) Co-authored-by: MichaelaHunter michaela1234@gmail.com
Co-authored-by: MichaelaHunter 60361569+MichaelaHunter@users.noreply.github.com](e813056) by jacobherrington
🛠️ Replace the initial migration for strong_migrations gem (#5865) by rhymes
🛠️ Return a 404 response If @event is Not Found (#5798) [deploy] by Zeko369
🛠️ Fix typo in ReactionObserver (#5834) [deploy] by Zhao-Andy
🛠️ chore: add a core team member (#5812) by Ridhwana
🛠️ add missing sha512 to ES mac docs (#5863) by mstruve
🛠️ Bump strong_migrations from 0.6.0 to 0.6.1 (#5853) by dependabot-preview[bot]
🛠️ User counters using PostgreSQL JSON (#5373) [deploy] Co-authored-by: Ben Halpern bendhalpern@gmail.com by rhymes
🛠️ Bump lint-staged from 10.0.3 to 10.0.7 (#5852) by dependabot-preview[bot]
🛠️ Bump @storybook/addons from 3.4.11 to 3.4.12 (#5843) by dependabot-preview[bot]
🛠️ Bump eslint-plugin-import from 2.20.0 to 2.20.1 (#5844) by dependabot-preview[bot]
🛠️ Bump pry-byebug from 3.7.0 to 3.8.0 (#5855) by dependabot-preview[bot]
🛠️ Bump rubocop-rails from 2.4.1 to 2.4.2 (#5858) by dependabot-preview[bot]
🛠️ Read Gemfile ruby from .ruby-version (#5780) by swrobel
🛠️ [Bump libhoney from 1.14.2 to 1.14.3 (#5859) [deploy] Bumps libhoney from 1.14.2 to 1.14.3.
Signed-off-by: dependabot-preview[bot] support@dependabot.com](9bf8656) by dependabot-preview[bot]
🛠️ [Bump parallel_tests from 2.30.1 to 2.31.0 (#5861) Bumps parallel_tests from 2.30.1 to 2.31.0.
Signed-off-by: dependabot-preview[bot] support@dependabot.com](068b5b5) by dependabot-preview[bot]
🛠️ Introduce Elasticsearch to DEV env (#5762) [deploy] by mstruve
🛠️ track stripe errors in Datadog so we can alert on them (#5797) by mstruve
CONTRIBUTORS
Last week there were 28 contributors.
👤 atsmith813
👤 lightalloy
👤 abdellani
👤 benhalpern
👤 maykonmenezes
👤 mstruve
👤 rhymes
👤 ludwiczakpawel
👤 nickytonline
👤 vaidehijoshi
👤 seb1441
👤 virajvchavan
👤 jacobherrington
👤 joshpuetz
👤 fredhase
👤 citizen428
👤 dependabot-preview[bot]
👤 Zhao-Andy
👤 deepu105
👤 juliannatetreault
👤 Computer-Man497
👤 fdoxyz
👤 gonzar11
👤 majakomel
👤 codekatas-magmalabs
👤 Zeko369
👤 Ridhwana
👤 swrobel
STARGAZERS
Last week there were 56 stagazers.
⭐ reyronald
⭐ lucas-santos
⭐ raikusy
⭐ MoskitoHero
⭐ sabbirshawon
⭐ almokhtarbr
⭐ Freshchris01
⭐ fdoxyz
⭐ mouadcherkaoui
⭐ prahaladbelavadi
⭐ wendellsborges
⭐ ndrsllwngr
⭐ bzvyyv
⭐ teekoksiang
⭐ loreBianchi
⭐ ArturJS
⭐ gaspetcan
⭐ MahmoudHaz
⭐ tuantuan1998
⭐ hientuminh
⭐ mshirdel
⭐ mtikoian
⭐ diegovisha
⭐ jolzee
⭐ abostan
⭐ isaacyeboah
⭐ odeloic
⭐ itsdyeyson
⭐ bradt6
⭐ uribou
⭐ joshuajansen
⭐ achimoraites
⭐ lgaitan
⭐ DevFojo
⭐ renesansz
⭐ shinnyx
⭐ T-SOD000
⭐ fariscc
⭐ elgin-labrin
⭐ nishasinha
⭐ rothanachoun
⭐ beppe9000
⭐ yorek
⭐ ripanioan
⭐ cyeet
⭐ gathuku
⭐ gustavogutkoski
⭐ reneecruz
⭐ Oscar-Raygoza
⭐ gnatson
⭐ ajstrand
⭐ m-torin
⭐ kemalelmizan
⭐ balazsbko
⭐ kySuga
⭐ sirluky
You all are the stars! 🌟
RELEASES
Last week there were no releases.
That's all for last week, please 👀 Watch and ⭐ Star the repository thepracticaldev/dev.to to receive next weekly updates. 😃
You can also view all Weekly Digests by clicking here.
The text was updated successfully, but these errors were encountered: