Allow admins to set brand color #10097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benhalpern
requested review from
jacobherrington and
juliannatetreault
and removed request for
a team
citizen428
reviewed
Aug 31, 2020
Co-authored-by: Michael Kohl <citizen428@dev.to>
pr-triage
bot
added
PR: partially-approved
citizen428
reviewed
Sep 1, 2020
| @@ -0,0 +1,11 @@ | |||
| module Color | |||
There was a problem hiding this comment.
Usually, we tend to use plurals for service name spaces, but don't let that stop this PR, I can change it during cooldown and potentially move the HecComparer into the Colors namespace too, keeping related things together and all.
citizen428
approved these changes
Sep 1, 2020
pr-triage
bot
added
PR: merged
citizen428
pushed a commit
that referenced
this pull request
Sep 3, 2020
* Allow admins to set brand color * Remove extra line * Fix linting * Update app/controllers/admin/configs_controller.rb Co-authored-by: Michael Kohl <citizen428@dev.to> * Move wcag compare to own class * Remove unnecessary spacing Co-authored-by: Michael Kohl <citizen428@dev.to>
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This feature allows admins to set their own main brand color....
This color needs to contrast properly with white, so I added the wcag contrast gem. I think this is a good gem to add, because we can start using this elsewhere, like user profile colors, tags, etc. Currently we let users set non-contrasting colors and basically just moderate it. This will help us ensure a minimum of 4.5:1 contrast for readability and accessibility for all.
The gem has not recently been updates, but it is a fairly simple low-bloat utility gem. The gem author is active and I feel like we can be comfortable that we could merge a change if we needed to.
Also added some basic validations in the controller. I figured we can start adding some validations in this area and extract these to a better place in a future refactor once we establish more of these.