Uncheck email preferences by default #10919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstruve
approved these changes
Oct 19, 2020
app/javascript/onboarding/components/__tests__/EmailPreferencesForm.test.jsx
Outdated
Show resolved
Hide resolved
pr-triage
bot
added
PR: partially-approved
…sForm.test.jsx Co-authored-by: Molly Struve <mollylbs@gmail.com>
pr-triage
bot
added
PR: unreviewed
benhalpern
approved these changes
Oct 19, 2020
pr-triage
bot
added
PR: partially-approved
pr-triage
bot
added
PR: merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#9876 What type of PR is this? (check all applicable)
Description
I recently noticed a potential GDPR issue in our onboarding flow: the email preference checkboxes should be deselected by default, see GDPR Recital 32:
This PR updates the
EmailPreferencesFormcomponent used during the onboarding flow and also changes the DB-level default value for these two columns fromtruetofalseso we have consistent behavior no matter how an account is created.Related Tickets & Documents
Closes https://github.com/forem/InternalProjectPlanning/issues/176
QA Instructions, Screenshots, Recordings
Go through the onboarding flow and verify that the following two checkboxes are unchecked by default:
Added tests?
Added to documentation?
[optional] What gif best describes this PR or how it makes you feel?