Fix a bug with moderator dropdowns and add aria tags

[Link2Twenty]

What type of PR is this? (check all applicable)

• Refactor
• Feature
• Bug Fix
• Optimization
• Documentation Update

Description

Fix a bug with moderator dropdowns and add aria tags.

Related Tickets & Documents

closes #13318

QA Instructions, Screenshots, Recordings

UI accessibility concerns?

I'm not really sure what this is meant to do, it looks like it just greys out other dropdowns unless they're open but then still allows click actions to work.

forem/app/javascript/actionsPanel/actionsPanel.js

Lines 371 to 380 in c842d1a

	Array.from(document.getElementsByClassName('other-things-btn')).forEach(
	(btn) => {
	btn.addEventListener('click', () => {
	btn.classList.toggle('active');
	const otherBtns = Array.from(
	document.getElementsByClassName('other-things-btn'),
	).filter((otherBtn) => otherBtn !== btn);
	otherBtns.forEach((otherBtn) => {
	otherBtn.classList.toggle('inactive');
	});

Added tests?

• Yes
• No, and this is why: old tests will still work
• I need help with writing tests

[optional] Are there any post deployment tasks we need to perform?

N/A

[optional] What gif best describes this PR or how it makes you feel?

[github-actions]

Thank you for opening this PR! We appreciate you!

For all pull requests coming from third-party forks we will need to
review the PR before we can process it through our CI pipelines.

A Forem Team member will review this contribution and get back to
you as soon as possible!

[Link2Twenty]

Didn't realise this was connected to #12297
I've now added aria-haspopup as is indicated in that issue.

[nickytonline]

Thanks as always @Link2Twenty for your contributions. Small change request.

[aitchiss]

I'm not really sure what this is meant to do, it looks like it just greys out other dropdowns unless they're open but then still allows click actions to work.

I think you're right 🤔 It's strange but I guess maybe it helps visually to understand which dropdown is currently open? I'm not convinced though 😆

[aitchiss]

Looks good to me! Thanks for this. I tested locally, including with Safari/VoiceOver and the expanded/collapsed states are now being announced too ✨

[nickytonline]

Thanks for making the changes @Link2Twenty and thanks so much for making Forem more accessible! 🔥