馃悰 Fix new comment dropdown issue #13661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Link2Twenty
requested review from
ludwiczakpawel and
aitchiss
and removed request for
a team
|
Thank you for opening this PR! We appreciate you! For all pull requests coming from third-party forks we will need to A Forem Team member will review this contribution and get back to |
nickytonline
suggested changes
May 5, 2021
app/assets/javascripts/initializers/initializeCommentsPage.js.erb
Outdated
Show resolved
Hide resolved
app/assets/javascripts/initializers/initializeCommentsPage.js.erb
Outdated
Show resolved
Hide resolved
pr-triage
bot
added
PR: reviewed-changes-requested
|
For future reference, when fixing a bug like this should I modernise adjacent code, even if it's not code I'm actively working on? |
Thanks for asking @Link2Twenty! I just mentioned it as it's a small fix since we're in this piece of code. If it was a larger refactor noticed while fixing an issue, I'd create a separate issue for that. |
pr-triage
bot
added
PR: unreviewed
nickytonline
approved these changes
May 6, 2021
pr-triage
bot
added
PR: partially-approved
ludwiczakpawel
approved these changes
May 6, 2021
pr-triage
bot
added
PR: merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
When you create a new comment on the comments page then try and access its menu no menu opens. This was caused by an error in JS.
Related Tickets & Documents
Loosely related to #13365
QA Instructions, Screenshots, Recordings
Before
After
UI accessibility concerns?
N/A
Added tests?
[optional] Are there any post deployment tasks we need to perform?
N/A
[optional] What gif best describes this PR or how it makes you feel?