Make comment box shrink on submit #13686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oyeyipo
requested review from
ludwiczakpawel and
nickytonline
and removed request for
a team
|
Thank you for opening this PR! We appreciate you! For all pull requests coming from third-party forks we will need to A Forem Team member will review this contribution and get back to |
rhymes
reviewed
May 7, 2021
app/assets/javascripts/initializers/initializeCommentsPage.js.erb
Outdated
Show resolved
Hide resolved
aitchiss
suggested changes
May 7, 2021
app/assets/javascripts/initializers/initializeCommentsPage.js.erb
Outdated
Show resolved
Hide resolved
pr-triage
bot
added
PR: reviewed-changes-requested
oyeyipo
force-pushed
the
oyeyipowale/shrink-commet-box
branch
from
5b27118
to
40ba833
Compare
rhymes
approved these changes
May 8, 2021
pr-triage
bot
added
PR: partially-approved
aitchiss
approved these changes
May 10, 2021
pr-triage
bot
added
PR: merged
|
Thanks for the fix @oyeyipowale! ✨ |
aitchiss
added
the
changelog: rollup
|
Great job @oyeyipowale ! Thanks for helping out and smashing this bug! |
|
@oyeyipowale would you mind making a quick post on DEV using this template. That way we can make sure you get the Bug Smash badge and stickers 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
The main comment box on the articles detail page does not reset to default height after successful submission. The inline style height set on the textarea element is not being removed.
Related Tickets & Documents
Fixes #13298
Added tests?
[optional] What gif best describes this PR or how it makes you feel?