Replace MAX_USER_MENTIONS with Settings::RateLimit.mention_creation

[vaidehijoshi]

What type of PR is this? (check all applicable)

• Optimization

Description

Addresses this TODO now that RFC #22 has been completed with #13367

forem/app/models/article.rb

Lines 28 to 30 in 11bab73

	# TODO: Vaidehi Joshi - Extract this into a constant or SiteConfig variable
	# after https://github.com/forem/rfcs/pull/22 has been completed?
	MAX_USER_MENTIONS = 7 # Explicitly set to 7 to accommodate DEV Top 7 Posts

Also removes my name from all the TODOs I added previously for myself 😿

Related Tickets & Documents

Follow up task to RFC #22

QA Instructions, Screenshots, Recordings

1. Check that you cannot create a post with more than 7 @-mentions (this is the default value for Settings::RateLimit.mention_creation):

2. Check that you can create a post with 7 or fewer @-mentions:

3. Check that you cannot create a comment with more than 7 @-mentions

4. Check that you can create a comment with 7 or fewer @-mentions:

5. Go to the admin view /admin/customization/config, and check that you can see the limit for @-mentions in a post or comment in the "rate limit and antispam" section:

6. Try changing that value and updating the config:

You should now only be able to create up to the new number of max mentions that you just set 😃

UI accessibility concerns?

A backend change, so...none!

Added tests?

• Yes

[Forem core team only] How will this change be communicated?

• I've updated the README or added inline documentation
• I will share this change in a Changelog
  or in a forem.dev post
• I will share this change internally with the appropriate teams

Are there any post deployment tasks we need to perform?

I don't think we have any; Settings::RateLimits are already in production, so everything should Just Work™️

[juliannatetreault]

This works like a charm locally! ✨

The only thing that stood out to me was the when I add @-mentions to posts, my editor seems to lag out--I'm only able to add a single character at a time when typing out a username and have to manually "refocus" my cursor within the editor to finish the @-mention. I tested this on main and experienced the same thing, so it doesn't seem like this is unique to your work (and might just be a "me" thing for all I know!), but I wanted to mention it just in case!

Also, 😿 at the removal of your name within the codebase.

[vaidehijoshi]

The only thing that stood out to me was the when I add @-mentions to posts, my editor seems to lag out--I'm only able to add a single character at a time when typing out a username and have to manually "refocus" my cursor within the editor to finish the @-mention. I tested this on main and experienced the same thing, so it doesn't seem like this is unique to your work (and might just be a "me" thing for all I know!), but I wanted to mention it just in case!

Interesting...I tried to repro this locally but my local editor's autocomplete functionality seems to be pretty snappy 🤔 If you're still seeing this locally (on main and after restarting your browser), then it might be worth opening up an issue for it! :)

[juliannatetreault]

The only thing that stood out to me was the when I add @-mentions to posts, my editor seems to lag out--I'm only able to add a single character at a time when typing out a username and have to manually "refocus" my cursor within the editor to finish the @-mention. I tested this on main and experienced the same thing, so it doesn't seem like this is unique to your work (and might just be a "me" thing for all I know!), but I wanted to mention it just in case!

Interesting...I tried to repro this locally but my local editor's autocomplete functionality seems to be pretty snappy 🤔 If you're still seeing this locally (on main and after restarting your browser), then it might be worth opening up an issue for it! :)

Okay... definitely sounds like a "me" thing then! I haven't restarted my browser yet, but I will definitely open an issue for it if it persists after restarting it. 😊

[vaidehijoshi]

Ahead of merging this PR, I've updated the Forem Admin Guide to include this new configuration! ✅