i18n: Translate core Create and Manage #15112
Conversation
|
Thank you for opening this PR! We appreciate you! For all pull requests coming from third-party forks we will need to A Forem Team member will review this contribution and get back to |
|
Hi @KrystalJean, thanks for contributing. Yes, it'd be great if you could follow the pattern of breaking out smaller views in |
|
The two strings are already covered by #15040. |
|
Ok, thanks for the heads-up @yheuhtozr! @KrystalJean Thanks a lot for your contribution, unfortunately, it seems like we'll have to close this PR since an earlier one already translated the same strings. |
|
To be accurate, the actual French translation is not included in #15040, so a later amendment is welcome. |
|
Okay, no problem @citizen428 and @yheuhtozr . I am sorry about that. I had found this to work on by searching bin/untranslated_erb. Could y'all recommend any other I18n that I might could help with that will not overlap? I am still needing two more pull request for Hacktoberfest. I know my contributions have been small, but I am really enjoying working on this code, and learning so much. |
|
Oh I wasn't aware of that event being an outsider. Most strings I provided are merely extracted but not translated. So replacing them with real French might be acceptable as contributions? @citizen428 |
|
Ok, cool thanks @yheuhtozr. Do you know if I have to wait until they are merged before I work on translating, or do I just add them as suggestions in your current pull request, and mine will be merged along with yours? |
|
@KrystalJean You can add them as suggestions in the other PR. |
|
Ok sounds good. Thanks @citizen428 and @yheuhtozr for helping me out. |
|
@KrystalJean Due to technical reasons (my GitHub repo is just a mirror), anything we add to my PR via GH won't be likely to last long. If you are planning to add something based on my contributions, I think opening independent PRs that overwrite my locale files (under |
|
Ok @yheuhtozr thanks for letting me know. So, I will make my own pull request. Should I reference your pull request in mine? |
|
@KrystalJean Thank you, that would be great for later traceability. |
What type of PR is this? (check all applicable)
Description
I followed existing patterns of internationalization from my previous merged commits. Please let me know if this should be under views instead of core, and I can change this.
Related Tickets & Documents
This PR references issue "Internationalize Hardcoded Display Text #14888".
QA Instructions, Screenshots, Recordings
Please replace this line with instructions on how to test your changes, a note
on the devices and browsers this has been tested on, as well as any relevant
images for UI changes.
UI accessibility concerns?
None
If your PR includes UI changes, please replace this line with details on how
accessibility is impacted and tested. For more info, check out the
Forem Accessibility Docs.
Added/updated tests?
[Forem core team only] How will this change be communicated?
Will this PR introduce a change that impacts Forem members or creators, the
development process, or any of our internal teams? If so, please note how you
will share this change with the people who need to know about it.
Storybook (for Crayons components)
updated. I have filled out the
Changes Requested
issue template so Community Success can help update the Admin Docs
appropriately.
CHANGELOG.mdor in a forem.dev post
replace this line with details on why this change doesn't need to be
shared
[optional] Are there any post deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?