Expanding the range of followed tags we show

[jeremyf]

What type of PR is this? (check all applicable)

• Bug Fix

Description

I have talked with @amywtlin about the expectations regarding the tags that one follows. This is the lightest weight fix to align with expected behavior.

The fix might be a bit of a work-around for a more general approach, but we're fighting against the magic of the points vs. explicit_points tension as defined in the Follows::UpdatePointsWorker.

That is to say, it's possible (and happens) where I have assigned an explicit_points of 1 for a tag, but the calculated points are less than 1. The calculated points are what we send forward in the AsyncInfoController (by way of the UserDecorator#cached_followed_tags method).

In DEV, I ran the following queries:

User assigned points >= 1 but calculated < 1

985,352 records

SELECT count(id)
FROM follows
WHERE followable_type = 'ActsAsTaggableOn::Tag'
  AND points < 1
  AND explicit_points >= 1;

User assigned points >= 1 but calculated >= 1

5,366,478 records

SELECT count(id)
FROM follows
WHERE followable_type = 'ActsAsTaggableOn::Tag'
  AND points >= 1
  AND explicit_points >= 1;

User assigned points >= 1 but calculated >= 0

0 records.

SELECT count(id)
FROM follows
WHERE followable_type = 'ActsAsTaggableOn::Tag'
  AND points <= 0
  AND explicit_points >= 1;

User assigned points <= 0 but calculated > 0

1,146 records

SELECT count(id)
FROM follows
WHERE followable_type = 'ActsAsTaggableOn::Tag'
  AND points > 0
  AND explicit_points <= 0;

Synthesizing that, almost 1 million tag follows of the total 6.3 million are not showing up in the user's left navigation. And 5.3 million are roughly correct.

In adjusting the logic, we're now going to have more tags showing up in the left. And just over 1,000 might now show up that would be unexpected.

Related Tickets & Documents

Closes #14937.

QA Instructions, Screenshots, Recordings

Hopefully with this change @robertandrews will see some more tags showing up.

UI accessibility concerns?

None.

Added/updated tests?

• No.

[Forem core team only] How will this change be communicated?

• I'm not sure how best to communicate this change and need help