Remove the "Getting Started" Section from the Config #16033

juliannatetreault · 2022-01-10T18:45:47Z

What type of PR is this? (check all applicable)

Description

This PR removes the "Getting Started" section, and the code related to this section, from /admin/customization/config. With the recent changes to the Creator Onboarding flow, this section is no longer useful.

Related Tickets & Documents

Relates to PR #15969 and more specifically, to this comment.

QA Instructions, Screenshots, Recordings

To QA this PR, please navigate to /admin/customization/config to ensure that everything still works as expected. Additionally, all checks should be green. ♻️

Before:

After:

UI accessibility concerns?

N/A

Added/updated tests?

Yes in the form of removing any related tests to the code that is being removed. ✂️
No, and this is why: please replace this line with details on why tests
have not been included
I need help with writing tests

[Forem core team only] How will this change be communicated?

Will this PR introduce a change that impacts Forem members or creators, the
development process, or any of our internal teams? If so, please note how you
will share this change with the people who need to know about it.

I've updated the Developer Docs or
Storybook (for Crayons components)
This PR changes the Forem platform and our documentation needs to be
updated. I have filled out the
Changes Requested. The issue for this request can be found here!
issue template so Community Success can help update the Admin Docs
appropriately.
I've updated the README or added inline documentation
I've added an entry to
CHANGELOG.md
I will share this change in a Changelog
or in a forem.dev post
I will share this change internally with the appropriate teams
I'm not sure how best to communicate this change and need help: what is the best way to communicate this change to the broader team and community?
This change does not need to be communicated, and this is why not: please
replace this line with details on why this change doesn't need to be
shared

[optional] Are there any post deployment tasks we need to perform?

N/A

[optional] What gif best describes this PR or how it makes you feel?

juliannatetreault · 2022-01-12T18:47:58Z

With this removal, should we also remove the red "Required" tags next to the "community name," "community description," "suggested users," and "suggested tags" fields? While they no longer appear in the "Get Started" section (since that has been removed 😄 ) they do appear next to the individual fields throughout the Config (for example, under "Community Content "-> "Community Name"). The "Required" tags do not align with the required fields during the Creator Onboarding flow, rather they appear next to any settings that have been deemed "Mandatory"--I feel as though this is slightly confusing. To add to the confusion, while there is a red "Required" tag next to "suggested tags" and "suggested users," I'm able to clear out both fields and leave them empty without running into any errors.

Thoughts, @Ridhwana?

Ridhwana · 2022-01-18T14:02:07Z

With this removal, should we also remove the red "Required" tags next to the "community name," "community description," "suggested users," and "suggested tags" fields?

Nice catch, yes please, let's do that.

To add to the confusion, while there is a red "Required" tag next to "suggested tags" and "suggested users," I'm able to clear out both fields and leave them empty without running into any errors.

Ooh, this is weird! but I guess something we can leave a mystery now that we're removing the "Required" 😅

…remove-get-started-section-from-config

Ridhwana

Thanks for this Julianna - I've left some comments and insights into the failing test. Let me know if you have any questions :)

app/javascript/admin/controllers/config_controller.js

app/helpers/application_helper.rb

nickytonline

This looks great and it appears you've addressed @Ridhwana's feedback. 🚀

nickytonline

🚀

Ridhwana

Looks great 🚀, thanks for addressing the feedback @juliannatetreault!

…user * main: (36 commits) Stripping tags from "tags.short_summary" column (#16248) Add host tag in ForemStatsClient (#16237) Configured the repository to handle line endings (#16234) Removed font-awesome from the admin section (#16239) fix (#16244) remove assignment of css variable to undefined (#16243) Add new tag autocomplete to editor (#16025) Color tokens (#16107) ListingsToolkit refactoring (#16184) Expanding the range of followed tags we show (#16213) Let override of ToS and CoC show in onboarding (#16217) Bump stripe from 5.42.0 to 5.43.0 (#16233) Bump flipper-active_record from 0.23.0 to 0.23.1 (#16231) Bump flipper-ui from 0.23.0 to 0.23.1 (#16232) Bump flipper-active_support_cache_store from 0.23.0 to 0.23.1 (#16230) Bump js-routes from 2.2.0 to 2.2.1 (#16229) Adds suggested_tags to Onboarding section in Config (#16228) Constantize broadcast messages (#16219) app/mailers i18n (#16191) Remove the "Getting Started" Section from the Config (#16033) ...

* Removes the Getting Started section and related code from the config * Removes the admin_manages_configuration_spec.rb * Removes "Required" tags from Config * Reverts removal of activateMissingKeysModal * Removes mandatory.rb

Removes the Getting Started section and related code from the config

7f841ff

pr-triage bot added the PR: draft bot applied label for PR's that are a work in progress label Jan 10, 2022

juliannatetreault mentioned this pull request Jan 10, 2022

Update "Forem Setup Checklist" Documentation forem/admin-docs#26

Closed

Removes the admin_manages_configuration_spec.rb

f0fbf65

juliannatetreault requested a review from Ridhwana January 12, 2022 16:02

juliannatetreault added 2 commits January 18, 2022 12:27

Merge branch 'main' of github.com:forem/forem into juliannatetreault/…

91bb5a8

…remove-get-started-section-from-config

Removes "Required" tags from Config

556f424

Ridhwana reviewed Jan 19, 2022

View reviewed changes

app/javascript/admin/controllers/config_controller.js Show resolved Hide resolved

app/javascript/admin/controllers/config_controller.js Show resolved Hide resolved

app/helpers/application_helper.rb Show resolved Hide resolved

juliannatetreault added 2 commits January 19, 2022 12:16

Reverts removal of activateMissingKeysModal

c4326a3

Removes mandatory.rb

493f40a

juliannatetreault changed the title ~~[Not Ready for Review]: Remove the "Getting Started" Section from the Config~~ Remove the "Getting Started" Section from the Config Jan 19, 2022

juliannatetreault requested review from nickytonline and Ridhwana and removed request for Ridhwana January 19, 2022 19:51

juliannatetreault marked this pull request as ready for review January 19, 2022 19:51

juliannatetreault requested review from a team January 19, 2022 19:51

pr-triage bot added PR: unreviewed bot applied label for PR's with no review and removed PR: draft bot applied label for PR's that are a work in progress labels Jan 19, 2022

juliannatetreault removed request for a team January 19, 2022 19:52

nickytonline reviewed Jan 19, 2022

View reviewed changes

nickytonline approved these changes Jan 19, 2022

View reviewed changes

pr-triage bot added PR: partially-approved bot applied label for PR's where a single reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Jan 19, 2022

citizen428 approved these changes Jan 20, 2022

View reviewed changes

Ridhwana approved these changes Jan 20, 2022

View reviewed changes

pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: partially-approved bot applied label for PR's where a single reviewer approves changes labels Jan 20, 2022

Merges in main and resolves merge conflicts

c9e8035

pr-triage bot added PR: unreviewed bot applied label for PR's with no review and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels Jan 20, 2022

juliannatetreault merged commit 615137a into main Jan 20, 2022

juliannatetreault deleted the juliannatetreault/remove-get-started-section-from-config branch January 20, 2022 14:31

pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: unreviewed bot applied label for PR's with no review labels Jan 20, 2022

juliannatetreault mentioned this pull request Jan 20, 2022

Add suggested_tags to "Onboarding" Section in Config #16228

Merged

16 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove the "Getting Started" Section from the Config #16033

Remove the "Getting Started" Section from the Config #16033

juliannatetreault commented Jan 10, 2022

juliannatetreault commented Jan 12, 2022

Ridhwana commented Jan 18, 2022

Ridhwana left a comment •

edited

Loading

nickytonline left a comment

nickytonline left a comment

Ridhwana left a comment

Remove the "Getting Started" Section from the Config #16033

Remove the "Getting Started" Section from the Config #16033

Conversation

juliannatetreault commented Jan 10, 2022

What type of PR is this? (check all applicable)

Description

Related Tickets & Documents

QA Instructions, Screenshots, Recordings

Before:

After:

UI accessibility concerns?

Added/updated tests?

[Forem core team only] How will this change be communicated?

[optional] Are there any post deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

juliannatetreault commented Jan 12, 2022

Ridhwana commented Jan 18, 2022

Ridhwana left a comment • edited Loading

Choose a reason for hiding this comment

nickytonline left a comment

Choose a reason for hiding this comment

nickytonline left a comment

Choose a reason for hiding this comment

Ridhwana left a comment

Choose a reason for hiding this comment

Ridhwana left a comment •

edited

Loading