Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove myself from the core team #16967

Merged

Conversation

nickytonline
Copy link
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Gonna miss you, friends! 馃憢馃徎

Related Tickets & Documents

  • Related Issue #
  • Closes #

QA Instructions, Screenshots, Recordings

N/A documentation change

UI accessibility concerns?

N/A documentation change

Added/updated tests?

  • Yes
  • No, and this is why: N/A documentation change
  • I need help with writing tests

[Forem core team only] How will this change be communicated?

Will this PR introduce a change that impacts Forem members or creators, the
development process, or any of our internal teams? If so, please note how you
will share this change with the people who need to know about it.

  • I've updated the Developer Docs or
    Storybook (for Crayons components)
  • This PR changes the Forem platform and our documentation needs to be
    updated. I have filled out the
    Changes Requested
    issue template so Community Success can help update the Admin Docs
    appropriately.
  • I've updated the README or added inline documentation
  • I've added an entry to
    CHANGELOG.md
  • I will share this change in a Changelog
    or in a forem.dev post
  • I will share this change internally with the appropriate teams
  • I'm not sure how best to communicate this change and need help
  • This change does not need to be communicated, and this is why not: please
    replace this line with details on why this change doesn't need to be
    shared

[optional] Are there any post deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

Moira from Schitt's Creek blowing a kiss to say goodbye

@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Mar 22, 2022
@nickytonline nickytonline requested review from a team and removed request for a team March 22, 2022 14:37
@pr-triage pr-triage bot added PR: partially-approved bot applied label for PR's where a single reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Mar 22, 2022
@djuber
Copy link
Contributor

djuber commented Mar 22, 2022

insert requisite sobbing emoji here 馃槶 馃槶 馃槶 馃槶 馃槶 馃槶 馃槶 馃槶 馃槶 馃槶 馃槶 馃槶 馃槶

Copy link
Contributor

@juliannatetreault juliannatetreault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the sobs 馃槶

@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: partially-approved bot applied label for PR's where a single reviewer approves changes labels Mar 22, 2022
Copy link
Contributor

@aitchiss aitchiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

crying

@nickytonline nickytonline merged commit 56f576c into main Mar 22, 2022
@nickytonline nickytonline deleted the nickytonline/remove-myself-from-core-contributors branch March 22, 2022 14:49
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels Mar 22, 2022
@joshpuetz
Copy link
Contributor

馃憥馃徎 LBTM

(Just kidding: all the best @nickytonline!)

@maestromac
Copy link
Member

馃槶

Copy link
Contributor

@andygeorge andygeorge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I revert this change???? 馃槶 鉂わ笍

@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: merged bot applied label for PR's that are merged labels Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: reviewed-approved bot applied label for PR's where reviewer approves changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants