Remove @storybook/addon-notes 5 from devDependencies #17399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
tnir
requested review from
a team,
aitchiss and
msarit
and removed request for
a team
|
Thank you for opening this PR! We appreciate you! For all pull requests coming from third-party forks we will need to A Forem Team member will review this contribution and get back to |
2 tasks
tnir
changed the title
aitchiss
approved these changes
Apr 22, 2022
There was a problem hiding this comment.
I took this for a spin locally, and it looks great!
I did notice locally when testing this that MentionAutocompleteTextArea has docs which aren't showing in Storybook, but this seems to have been broken some time ago 馃槄 I'll make a note to fix that up separately.
pr-triage
bot
added
PR: partially-approved
jeremyf
approved these changes
Apr 22, 2022
pr-triage
bot
added
PR: merged
63 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Takuya Noguchi takninnovationresearch@gmail.com
What type of PR is this? (check all applicable)
Description
Removes @storybook/addon-notes 5 from devDependencies since Storybook 6 deprecated it in 2020.
This removes 485 (effective) lines from
yarn.lock馃帀 and 55 (effective) packages 馃帀 馃帀 including poper.js v1 馃嵖 .Related Tickets & Documents
QA Instructions, Screenshots, Recordings
Access to https://storybook.forem.com/?path=/docs/components-buttons--default to see if it works.
path=/docs/in URL means the former "note" before upgrading to Storybook 6.x.These screenshots are for if no regression happens and just for future reference:
Notes was renamed as Docs
No more Notes tab in the bottom panel after #9766
UI accessibility concerns?
n/a
Added/updated tests?
gif
馃槍