Create new feed-variant 20220422 #17406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maestromac
requested review from
a team and
jgaskins
and removed request for
a team
maestromac
commented
Apr 22, 2022
Comment on lines
+70
to
+89
| "matching_negative_tags_intersection_count": { | ||
| "cases": [ | ||
| [0, 1], | ||
| [1, 0.8], | ||
| [2, 0.5], | ||
| [3, 0.3], | ||
| [4, 0.2] | ||
| ], | ||
| "fallback": 0 | ||
| }, | ||
| "matching_positive_tags_intersection_count": { | ||
| "cases": [ | ||
| [0, 0.7], | ||
| [1, 0.85], | ||
| [2, 0.93], | ||
| [3, 0.98], | ||
| [4, 1] | ||
| ], | ||
| "fallback": 1 | ||
| }, |
msarit
approved these changes
Apr 22, 2022
pr-triage
bot
added
PR: partially-approved
jeremyf
reviewed
Apr 22, 2022
| @@ -189,7 +189,7 @@ def self.lever_catalog | |||
| AND comments.deleted = false | |||
| AND comments.created_at > :oldest_published_at"]) | |||
|
|
|||
| relevancy_lever(:matching_negative_tag_intersection_count, | |||
| relevancy_lever(:matching_negative_tags_intersection_count, | |||
There was a problem hiding this comment.
Good catch on consistent naming!
jeremyf
suggested changes
Apr 22, 2022
There was a problem hiding this comment.
It may look like I want to request changes, but really I don't want to accidentally merge this. @JennieOcken wants this to go live on Monday.
pr-triage
bot
added
PR: reviewed-changes-requested
|
For those reading along, we don't need tests because in spec/services/articles/feeds/variant_query_spec.rb we test all variants in that directory. |
jeremyf
approved these changes
Apr 22, 2022
pr-triage
bot
added
PR: partially-approved
pr-triage
bot
added
PR: merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Add a new feed-variant as per Jennie's request. Shoutout to @jeremyf and @msarit
Related Tickets & Documents
n/a
QA Instructions, Screenshots, Recordings
n/a
Added tests?
Added to documentation?
[optional] Are there any post deployment tasks we need to perform?
n/a