Member index: controls layout refactor #17927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pr-triage
bot
added
the
PR: draft
aitchiss
commented
Jun 15, 2022
| @@ -1,6 +1,36 @@ | |||
| <%= javascript_packs_with_chunks_tag "admin/users/controls", defer: true %> | |||
| <% if params[:controller] == "admin/users" %> | |||
There was a problem hiding this comment.
We didn't need this, since we only use this partial on the member index page 🤷♀️ I think perhaps we missed removing it in a refactor at some point
pr-triage
bot
added
PR: unreviewed
aitchiss
requested review from
a team,
Ridhwana and
msarit
and removed request for
a team
fdocr
approved these changes
Jun 15, 2022
pr-triage
bot
added
PR: partially-approved
pr-triage
bot
added
PR: merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This PR shuffles around the alignment and position of the "controls" on
/admin/member_manager/users. This reshuffle is behind themember_index_viewfeature flag, and the old code can/should be removed when we ship phase 2.I decided in the end to place it behind the feature flag to avoid complexity with including the "filter by role" view on the index page vs in the new filters modal. Having it behind the feature flag will make it more straightforward to extricate the old code.
Related Tickets & Documents
QA Instructions, Screenshots, Recordings
All changes are contained within
/admin/member_manager/users.member_index_viewfeature flag disabled, you should see no change to the current UI. Filtering by role and searching should continue to work as expected. Expandable search/filter functionality on smaller screens should continue to functionmember_index_viewfeature flag enabled, the UI should match the breakpoints detailed in Figma, the search functionality should continue to work as expected, expandable search section on small screens should continue to work, and the filter button should pop open the new filters modalCleanShot.2022-06-15.at.14.11.52.mp4
UI accessibility concerns?
None, just reshuffling elements
Added/updated tests?
[Forem core team only] How will this change be communicated?
Will this PR introduce a change that impacts Forem members or creators, the
development process, or any of our internal teams? If so, please note how you
will share this change with the people who need to know about it.
Storybook (for Crayons components)
updated. I have filled out the
Changes Requested
issue template so Community Success can help update the Admin Docs
appropriately.
CHANGELOG.mdor in a forem.dev post
[optional] What gif best describes this PR or how it makes you feel?