More themeable mixin in action #2646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickytonline
commented
May 1, 2019
| @@ -686,8 +695,7 @@ a.header-link { | |||
| font-size: 12px; | |||
| text-align: right; | |||
| a { | |||
| color: $medium-gray; | |||
| color: var(--theme-secondary-color, $dark-gray); | |||
| @include themeable(color, theme-secondary-color, $medium-gray); | |||
There was a problem hiding this comment.
Question here... $medium-gray or $dark-gray?
There was a problem hiding this comment.
Nice catch. The previous code was broken. I guess we'll see if this looks wrong, but I think it's going back to what it was before.
nickytonline
commented
May 1, 2019
| @@ -780,8 +788,7 @@ a.header-link { | |||
| } | |||
| } | |||
| a { | |||
| color: lighten($dark-gray, 3%); | |||
| color: var(--theme-secondary-color, $dark-gray); | |||
| @include themeable(color, theme-secondary-color, lighten($dark-gray, 3%)); | |||
There was a problem hiding this comment.
Question here... lighten($dark-gray, 3%) or $dark-gray?
nickytonline
commented
May 1, 2019
| @@ -147,7 +150,11 @@ | |||
| outline: none; | |||
| font-weight: bold; | |||
| color: #333333; | |||
| font-family: "HelveticaNeue-CondensedBold", "HelveticaNeueBoldCondensed", "HelveticaNeue-Bold-Condensed", "Helvetica Neue Bold Condensed", "HelveticaNeueBold", "HelveticaNeue-Bold", "Helvetica Neue Bold", "HelveticaNeue", "Helvetica Neue", "TeXGyreHerosCnBold", "Helvetica", "Tahoma", "Geneva", "Arial Narrow", "Arial", sans-serif; | |||
| font-family: 'HelveticaNeue-CondensedBold', 'HelveticaNeueBoldCondensed', | |||
There was a problem hiding this comment.
Just some linting in action here.
nickytonline
changed the title
pr-triage
bot
added
PR: reviewed-approved
This was referenced May 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Continuing on the refactor of using the
themeableSASS mixin.Related Tickets & Documents
#2539
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
N/A
Added to documentation?
[optional] What gif best describes this PR or how it makes you feel?