Onboarding bug fix

[nicolas-amabile]

What type of PR is this? (check all applicable)

• Refactor
• Feature
• Bug Fix
• Documentation Update

Description

I've seen that there are some PRs (#3391, #3390 and #3388 for example) failing because of this issue:

Undefined followedTags on getUserTags (app/javascript/src/Onboarding.jsx file) is not being handle properly.

The first commit (196bcfa) only fixes some ESLint issues, and the following commit (276b8ec) is the actual fix.

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Added to documentation?

• docs.dev.to
• readme
• no documentation needed

[CLAassistant]

All committers have signed the CLA.

[rhymes]

Hi, good catch about the improved logic even though that's not why they are failing. That error is indeed logged but if you check closely (just scroll to the end of the build logs) those PRs are not failing because of a JS error but because there's a vulnerability out for omniauth:

ruby-advisory-db: 372 advisories
Name: omniauth
Version: 1.9.0
Advisory: CVE-2015-9284
Criticality: High
URL: https://github.com/omniauth/omniauth/pull/809
Title: CSRF vulnerability in OmniAuth's request phase
Solution: remove or disable this gem until a patch is available!
Vulnerabilities found!
The command "bundle exec bundle-audit check --update" exited with 1.

which unfortunately is blocking all deploys

[nicolas-amabile]

Hi, good catch about the improved logic even though that's not why they are failing. That error is indeed logged but if you check closely (just scroll to the end of the build logs) those PRs are not failing because of a JS error but because there's a vulnerability out for omniauth:

ruby-advisory-db: 372 advisories
Name: omniauth
Version: 1.9.0
Advisory: CVE-2015-9284
Criticality: High
URL: https://github.com/omniauth/omniauth/pull/809
Title: CSRF vulnerability in OmniAuth's request phase
Solution: remove or disable this gem until a patch is available!
Vulnerabilities found!
The command "bundle exec bundle-audit check --update" exited with 1.

which unfortunately is blocking all deploys

Got it 👍I thought the first error makes the build fail. Thanks!

[Zhao-Andy]

Hey @nicolas-amabile, thanks for your first PR! We’re actually going to merge it into @aspittel’s PR since she’s been actively working on the onboarding feature itself, and we’ve since taken it in a different direction.

We’ll be happy to proceed once you’ve signed the CLA.

[maestromac]

Merged into #3333