Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centre with flex rather than padding #4368

Merged
merged 1 commit into from
Oct 14, 2019
Merged

Centre with flex rather than padding #4368

merged 1 commit into from
Oct 14, 2019

Conversation

Link2Twenty
Copy link
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Documentation Update

Description

Rather than centring the preview with padding (which may not always be correct) move to flex to calculate for you.

Related Tickets & Documents

#4212

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

N/A

Added to documentation?

  • docs.dev.to
  • readme
  • no documentation needed

[optional] What gif best describes this PR or how it makes you feel?

Toy fixer

Rather than centring the preview with padding (which may not always be correct) move to flex to calculate for you.
@Link2Twenty Link2Twenty requested a review from a team October 11, 2019 12:01
@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Oct 11, 2019
@ghost ghost requested review from Zhao-Andy and removed request for a team October 11, 2019 12:01
Copy link
Contributor

@Zhao-Andy Zhao-Andy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Oct 11, 2019
@benhalpern benhalpern merged commit b0bf4ae into forem:master Oct 14, 2019
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels Oct 14, 2019
RakChamp25 pushed a commit to RakChamp25/dev.to that referenced this pull request Oct 15, 2019
Rather than centring the preview with padding (which may not always be correct) move to flex to calculate for you.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants