Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change BustReactableCacheJob to BustReactableCacheWorker and move to sidekiq #5582

Merged
merged 6 commits into from
Feb 12, 2020
Merged

Change BustReactableCacheJob to BustReactableCacheWorker and move to sidekiq #5582

merged 6 commits into from
Feb 12, 2020

Conversation

luchiago
Copy link
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Related Tickets & Documents

#5305

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Added to documentation?

  • docs.dev.to
  • readme
  • no documentation needed

@luchiago luchiago requested a review from a team January 19, 2020 04:47
@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Jan 19, 2020
rhymes
rhymes suggested changes Jan 19, 2020
View reviewed changes
Copy link
Contributor

@rhymes rhymes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @luchiago, thanks for this PR as well!

As reactions are an high frequency object and one of these is called in their after_save, I think it should be split in two steps.

@pr-triage pr-triage bot added PR: reviewed-changes-requested bot applied label for PR's where reviewer requests changes and removed PR: unreviewed bot applied label for PR's with no review labels Jan 19, 2020
@luchiago
Copy link
Contributor Author

@rhymes Sure, I'll revert the commit and push the changes

@pr-triage pr-triage bot added PR: unreviewed bot applied label for PR's with no review and removed PR: reviewed-changes-requested bot applied label for PR's where reviewer requests changes labels Jan 19, 2020
rhymes
rhymes reviewed Jan 22, 2020
View reviewed changes
Copy link
Contributor

@rhymes rhymes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @luchiago, I think after removing the parameter as @citizen428 suggested this can be ready for merging :)

app/workers/reactions/bust_reactable_cache_worker.rb Outdated Show resolved Hide resolved
@luchiago
Copy link
Contributor Author

@rhymes. Sure!

mstruve
mstruve suggested changes Jan 22, 2020
View reviewed changes
Copy link
Contributor

@mstruve mstruve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we need to make sure this method is done in an after_commit block to ensure everything we need to bust the cache is in the database. cc @rhymes

Thanks for another great PR!!!!

app/models/reaction.rb Show resolved Hide resolved
@pr-triage pr-triage bot added PR: reviewed-changes-requested bot applied label for PR's where reviewer requests changes PR: unreviewed bot applied label for PR's with no review and removed PR: unreviewed bot applied label for PR's with no review PR: reviewed-changes-requested bot applied label for PR's where reviewer requests changes labels Jan 22, 2020
mstruve
mstruve suggested changes Jan 28, 2020
View reviewed changes
app/models/reaction.rb Show resolved Hide resolved
@pr-triage pr-triage bot added PR: reviewed-changes-requested bot applied label for PR's where reviewer requests changes and removed PR: unreviewed bot applied label for PR's with no review labels Jan 28, 2020
This was referenced Feb 3, 2020
Closed
Closed
@pr-triage pr-triage bot added PR: unreviewed bot applied label for PR's with no review and removed PR: reviewed-changes-requested bot applied label for PR's where reviewer requests changes labels Feb 11, 2020
@luchiago
Copy link
Contributor Author

Ready for merge @rhymes @mstruve

@citizen428
Copy link
Contributor

Thanks for the updates @luchiago, we'll hopefully get around to merge this soon.

@rhymes rhymes requested a review from mstruve February 12, 2020 10:17
rhymes
rhymes approved these changes Feb 12, 2020
View reviewed changes
Copy link
Contributor

@rhymes rhymes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @luchiago, thanks for the changes!

mstruve
mstruve approved these changes Feb 12, 2020
View reviewed changes
Copy link
Contributor

@mstruve mstruve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@mstruve mstruve merged commit d0b4ba2 into forem:master Feb 12, 2020
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: unreviewed bot applied label for PR's with no review labels Feb 12, 2020
@atsmith813 atsmith813 mentioned this pull request Feb 13, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@citizen428 citizen428 citizen428 left review comments

@rhymes rhymes rhymes approved these changes

@mstruve mstruve mstruve approved these changes

Assignees
No one assigned
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@luchiago @citizen428 @rhymes @mstruve