Worker/user self delete #5698
Merged
Worker/user self delete #5698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstruve
suggested changes
Jan 24, 2020
| class SelfDeleteWorker | ||
| include Sidekiq::Worker | ||
|
|
||
| sidekiq_options queue: :high_priority, retry: 10 | ||
|
|
||
| def perform(user_id, service = Users::Delete) |
There was a problem hiding this comment.
Since we are not using this service argument can you remove it and explicitly call the service below?
Users::Delete.call(user)
pr-triage
bot
added
PR: reviewed-changes-requested
pr-triage
bot
added
PR: unreviewed
rhymes
approved these changes
Jan 26, 2020
There was a problem hiding this comment.
Looks good @maykonmenezes, thank you for this PR!
As a general rule don't forget to name your branches maykonmenezes/TOPIC-ISSUE_ID in the future, you can check the contributing guide on the details.
pr-triage
bot
added
PR: reviewed-approved
mstruve
approved these changes
Jan 27, 2020
pr-triage
bot
added
PR: merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Moving user self delete job to sidekiq
Related Tickets & Documents
#5305
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Added to documentation?
[optional] What gif best describes this PR or how it makes you feel?