Remove non-indexable logged-out links #5713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhymes
previously approved these changes
Jan 26, 2020
| <%= javascript_pack_tag "profileDropdown", defer: true %> | ||
| <a href="/report-abuse?url=https://dev.to/<%= @user.username %>">Report Abuse</a> | ||
| <% if user_signed_in? %> | ||
| <%= javascript_pack_tag "profileDropdown", defer: true %> |
There was a problem hiding this comment.
less JS for non logged in users! yay!
pr-triage
bot
added
PR: reviewed-approved
pr-triage
bot
added
PR: unreviewed
benhalpern
changed the title
rhymes
approved these changes
Jan 27, 2020
pr-triage
bot
added
PR: reviewed-approved
pr-triage
bot
added
PR: merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
I saw in our search console dashboard that Google is crawling some user-only pages because we link to them in non-logged-in views. There is still a layer of authentication, so it's not a problem other than likely waisting the crawler's time (which could hurt our SEO).
This feature adds a check for
user_signed_in?where functionality is only needed for signed-in users and the link does not need to be crawled by search engines.Also addednofollowon some links that should still exist for non-logged-in users but are not links to indexable content per se.I removed the "nofollow links" part of this PR because I had hesitations about the exact right choice. Everything else should be a no-brainer.