Handle Missing Root Comment in Deleted Comment View

[mstruve]

What type of PR is this? (check all applicable)

• Bug Fix

Description

Saw this error come through Honeybadger where the root comment was missing for a view so I added a blank check to the view to handle this situation.

ActionView::Template::Error: undefined method `deleted' for nil:NilClass
deleted_commentable_comment.html.erb  6 _app_views_comments_deleted_commentable_comment_html_erb___245802387296255488_73890320(...)
[PROJECT_ROOT]/app/views/comments/deleted_commentable_comment.html.erb:6:in `_app_views_comments_deleted_commentable_comment_html_erb___245802387296255488_73890320'
4   <div class="single-comment-node root">
5     <% @user ||= @root_comment.user %>
6     <% if @root_comment.deleted %>
7       <div class="inner-comment">
8         <div class="body">

Added to documentation?

• no documentation needed

[optional] What gif best describes this PR or how it makes you feel?

[atsmith813]

LGTM 💯

[rhymes]

Would it be possible to add a test for this? :)

It can also be done in a separate PR but still, I think we should get into the habit of testing code that can possibly become a regression, especially if it's a bug that ends up in HB. This way we create a habit and less future alerts in HB ;)

[mstruve]

Since I got the reviews and this is a small change, I'm going to push it out as is but I do agree with you @rhymes