Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove follows create chat channel job #5718

Merged
merged 1 commit into from
Jan 27, 2020
Merged

Remove follows create chat channel job #5718

merged 1 commit into from
Jan 27, 2020

Conversation

wildeng
Copy link
Contributor

@wildeng wildeng commented Jan 24, 2020

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Removed follows create chat channel delayed job

Related Tickets & Documents

#5305

Added to documentation?

  • docs.dev.to
  • readme
  • no documentation needed

weird

Remove follows create chat channel job
4326132 
  * Removed follows create chat channel delayed job
  * Removed related specs
@wildeng wildeng requested a review from a team January 24, 2020 22:02
@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Jan 24, 2020
rhymes
rhymes approved these changes Jan 26, 2020
View reviewed changes
Copy link
Contributor

@rhymes rhymes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wildeng!

Don't forget to name your branches wildeng/TOPIC-ISSUE_NUMBER in the future ;-)

@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Jan 26, 2020
@wildeng
Copy link
Contributor Author

wildeng commented Jan 27, 2020

Thanks @wildeng!

Don't forget to name your branches wildeng/TOPIC-ISSUE_NUMBER in the future ;-)

LOL I mixed two ways of naming branches - my current job and contributing here :)

mstruve
mstruve approved these changes Jan 27, 2020
View reviewed changes
Copy link
Contributor

@mstruve mstruve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@mstruve mstruve merged commit ca4c396 into forem:master Jan 27, 2020
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels Jan 27, 2020
@weekly-digest weekly-digest bot mentioned this pull request Feb 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhymes rhymes rhymes approved these changes

@mstruve mstruve mstruve approved these changes

Assignees
No one assigned
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wildeng @rhymes @mstruve