Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rubocop complaints #5769

Merged
merged 2 commits into from
Jan 27, 2020
Merged

Fix rubocop complaints #5769

merged 2 commits into from
Jan 27, 2020

Conversation

rhymes
Copy link
Contributor

@rhymes rhymes commented Jan 27, 2020

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Some small rubocop fixes and a few less "lines too long" :)

@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Jan 27, 2020
vaidehijoshi
vaidehijoshi previously approved these changes Jan 27, 2020
View reviewed changes
@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Jan 27, 2020
benhalpern
benhalpern requested changes Jan 27, 2020
View reviewed changes
Copy link
Contributor

@benhalpern benhalpern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there is a class mismatch in the tests

@pr-triage pr-triage bot added PR: reviewed-changes-requested bot applied label for PR's where reviewer requests changes and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels Jan 27, 2020
@rhymes
Copy link
Contributor Author

rhymes commented Jan 27, 2020

Thanks @benhalpern, I might have exaggerated in the copy and pasting :D Going to fix it

@pr-triage pr-triage bot added PR: unreviewed bot applied label for PR's with no review and removed PR: reviewed-changes-requested bot applied label for PR's where reviewer requests changes labels Jan 27, 2020
maestromac
maestromac approved these changes Jan 27, 2020
View reviewed changes
Copy link
Contributor

@maestromac maestromac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pr-triage pr-triage bot removed the PR: unreviewed bot applied label for PR's with no review label Jan 27, 2020
@pr-triage pr-triage bot added the PR: reviewed-approved bot applied label for PR's where reviewer approves changes label Jan 27, 2020
@benhalpern benhalpern merged commit 0927c81 into forem:master Jan 27, 2020
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels Jan 27, 2020
@rhymes rhymes deleted the rhymes/rubocop-fixes branch January 28, 2020 08:40
@weekly-digest weekly-digest bot mentioned this pull request Feb 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benhalpern benhalpern benhalpern approved these changes

@maestromac maestromac maestromac approved these changes

@vaidehijoshi vaidehijoshi Awaiting requested review from vaidehijoshi

Assignees
No one assigned
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rhymes @benhalpern @vaidehijoshi @maestromac