Improve API podcast episodes controller caching and fetching #5772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaidehijoshi
approved these changes
Jan 27, 2020
| respond_to :json | ||
|
|
||
| before_action :cors_preflight_check | ||
| after_action :cors_set_access_control_headers | ||
|
|
||
| before_action :set_cache_control_headers, only: %i[index] |
pr-triage
bot
added
PR: reviewed-approved
benhalpern
approved these changes
Jan 27, 2020
There was a problem hiding this comment.
This looks good to me, and is technically the right choice here all in all, but as you alluded to, we need further discussions.
Basically all my reactions here are "this works, but let's get on the same page before taking this too far" so let's find some time next week to discuss this alongside other folks from the team.
pr-triage
bot
added
PR: merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Similar to #5709 we're removing server side caching, adding edge caching and busting and some tests
I haven't added the usual
.purgecall because it's already present, though I'm not sure we need to call it twice, but I'd rather keep things as is in the cache buster for now and then go over it with a fine tooth comb:https://github.com/thepracticaldev/dev.to/blob/743ac13cec56f50694b00c3874b9d5ce009ccdc6/app/labor/cache_buster.rb#L146-L159
Related Tickets & Documents
#5709