Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Webhook::DispatchEventJob and spec #5774

Merged
merged 1 commit into from
Jan 27, 2020
Merged

Remove Webhook::DispatchEventJob and spec #5774

merged 1 commit into from
Jan 27, 2020

Conversation

atsmith813
Copy link
Contributor

What type of PR is this? (check all applicable)

  • Refactor

Description

Now that #5722 is merged, this is removing the old job.

Related Tickets & Documents

Added to documentation?

  • no documentation needed

power_rangers_see_ya_gif

@atsmith813 atsmith813 requested a review from a team January 27, 2020 20:28
@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Jan 27, 2020
maestromac
maestromac approved these changes Jan 27, 2020
View reviewed changes
Copy link
Contributor

@maestromac maestromac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's quite a gif

@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Jan 27, 2020
mstruve
mstruve approved these changes Jan 27, 2020
View reviewed changes
Copy link
Contributor

@mstruve mstruve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve just bc of the GIF

@atsmith813 atsmith813 merged commit 26e4412 into forem:master Jan 27, 2020
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels Jan 27, 2020
@weekly-digest weekly-digest bot mentioned this pull request Feb 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mstruve mstruve mstruve approved these changes

@vaidehijoshi vaidehijoshi vaidehijoshi approved these changes

@maestromac maestromac maestromac approved these changes

@citizen428 citizen428 Awaiting requested review from citizen428

@rhymes rhymes Awaiting requested review from rhymes

Assignees
No one assigned
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@atsmith813 @mstruve @vaidehijoshi @maestromac