Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove actionpack-action_caching gem #5787

Merged
merged 1 commit into from
Jan 28, 2020
Merged

Remove actionpack-action_caching gem #5787

merged 1 commit into from
Jan 28, 2020

Conversation

rhymes
Copy link
Contributor

@rhymes rhymes commented Jan 28, 2020

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Getting rid of this gem has been a long lasting dream of mine, I'm glad we've finally got to it thanks to the work we've been doing on streamlining edge caching. Page caching has been removed from Rails in version 4 (almost 7 years ago I just found out)

Next up is to get rid of rails-observers :D

@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Jan 28, 2020
Copy link
Contributor

@vaidehijoshi vaidehijoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨very nice! ✨

@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Jan 28, 2020
@mstruve mstruve merged commit 1d701c7 into forem:master Jan 28, 2020
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels Jan 28, 2020
@rhymes rhymes deleted the rhymes/remove-actionpack-action_caching-gem branch January 28, 2020 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants