Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker images #500

Closed
orhun opened this issue Oct 1, 2022 · 1 comment
Closed

Docker images #500

orhun opened this issue Oct 1, 2022 · 1 comment
Milestone
v0.16.0

Comments

@orhun
Copy link
Contributor

orhun commented Oct 1, 2022

Hello!

Is adding a Dockerfile for cargo-msrv and publishing Docker images on the roadmap?

This could be beneficial in a couple of ways:

  1. Containerization.
  2. A dedicated GitHub action could be created. (*)
  3. Docker image could be utilized in GitLab CI.

I would like to work on a Dockerfile if this is applicable.
@foresterre
Copy link
Owner

It wasn't on the roadmap, but I would be happy to put it on the roadmap as I can see the added benefit 😄.

@foresterre foresterre added this to the v0.17.0 milestone Oct 1, 2022
@orhun orhun mentioned this issue Oct 5, 2022
Merged
orhun added a commit to orhun/cargo-msrv that referenced this issue Oct 5, 2022
@orhun
Add Dockerfile (foresterre#500)
156ad5f
@orhun orhun mentioned this issue Oct 5, 2022
Merged
2 tasks
bors bot added a commit that referenced this issue Oct 7, 2022
@bors @orhun
Merge #503
6cf6d74 
503: Add Dockerfile r=foresterre a=orhun

See #500



Co-authored-by: Orhun Parmaksız <orhunparmaksiz@gmail.com>
bors bot added a commit that referenced this issue Oct 7, 2022
@bors @orhun
Merge #504
2169194 
504: Add Docker build/push workflow r=foresterre a=orhun

This PR adds a new GitHub actions workflow file for building/pushing Docker images to GHCR & Docker Hub.

Depends on #503, also see #500 

Todos:

- [x] Update workflow to clarify which Docker Hub account should be used for pushing Docker images (see `TODO_DOCKERHUB_USERNAME`)
  - `@foresterre` let me know your Docker Hub username and I can update the PR!
- [x] Add [Docker Hub access token](https://docs.docker.com/docker-hub/access-tokens/) as an [action secret](https://docs.github.com/en/codespaces/managing-codespaces-for-your-organization/managing-encrypted-secrets-for-your-repository-and-organization-for-github-codespaces) to the repository. It should be named as `DOCKER_TOKEN`.
   - needs action from `@foresterre` 

Co-authored-by: Orhun Parmaksız <orhunparmaksiz@gmail.com>
@foresterre foresterre modified the milestones: v0.17.0, v0.16.0 Oct 21, 2022
bors bot added a commit that referenced this issue Feb 8, 2023
@bors @dependabot
Merge #614
530ad31 
614: Bump petgraph from 0.6.2 to 0.6.3 r=foresterre a=dependabot[bot]

Bumps [petgraph](https://github.com/petgraph/petgraph) from 0.6.2 to 0.6.3.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/petgraph/petgraph/blob/master/RELEASES.rst">petgraph's changelog</a>.</em></p>
<blockquote>
<h1>Version 0.6.3 (2023-02-07)</h1>
<ul>
<li>Added an iterator over subgraph isomorphisms (<code>[#500](https://github.com/petgraph/petgraph/issues/500)</code>_)</li>
<li>Added serde support on <code>GraphMap</code> (<code>[#496](https://github.com/petgraph/petgraph/issues/496)</code>_)</li>
<li>Added <code>reverse</code> method for <code>StableGraph</code> (<code>[#533](https://github.com/petgraph/petgraph/issues/533)</code>_)</li>
<li>Added <code>edges_connecting</code> iterator for <code>StableGraph</code> (<code>[#521](https://github.com/petgraph/petgraph/issues/521)</code>_)</li>
<li>Fix Floyd-Warshall algorithm behaviour on undirected graphs (<code>487</code>_)</li>
<li>Fix IntoEdgesDirected implementation for NodeFiltered when direction is Incoming (<code>476</code>_)</li>
<li>Fix cardinality check in subgraph isomorphism (<code>472</code>_)</li>
<li>Fix UB in <code>MatrixGraph</code> (<code>[#505](https://github.com/petgraph/petgraph/issues/505)</code>_)</li>
</ul>
<p>.. _<code>[#472](https://github.com/petgraph/petgraph/issues/472)</code>: <a href="https://github-redirect.dependabot.com/petgraph/petgraph/issues/472">petgraph/petgraph#472</a>
.. _<code>[#476](https://github.com/petgraph/petgraph/issues/476)</code>: <a href="https://github-redirect.dependabot.com/petgraph/petgraph/issues/476">petgraph/petgraph#476</a>
.. _<code>[#487](https://github.com/petgraph/petgraph/issues/487)</code>: <a href="https://github-redirect.dependabot.com/petgraph/petgraph/issues/487">petgraph/petgraph#487</a>
.. _<code>[#496](https://github.com/petgraph/petgraph/issues/496)</code>: <a href="https://github-redirect.dependabot.com/petgraph/petgraph/issues/496">petgraph/petgraph#496</a>
.. _<code>[#500](https://github.com/petgraph/petgraph/issues/500)</code>: <a href="https://github-redirect.dependabot.com/petgraph/petgraph/issues/500">petgraph/petgraph#500</a>
.. _<code>[#505](https://github.com/petgraph/petgraph/issues/505)</code>: <a href="https://github-redirect.dependabot.com/petgraph/petgraph/issues/505">petgraph/petgraph#505</a>
.. _<code>[#521](https://github.com/petgraph/petgraph/issues/521)</code>: <a href="https://github-redirect.dependabot.com/petgraph/petgraph/issues/521">petgraph/petgraph#521</a>
.. _<code>[#533](https://github.com/petgraph/petgraph/issues/533)</code>: <a href="https://github-redirect.dependabot.com/petgraph/petgraph/issues/533">petgraph/petgraph#533</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li>See full diff in <a href="https://github.com/petgraph/petgraph/commits/0.6.3">compare view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=petgraph&package-manager=cargo&previous-version=0.6.2&new-version=0.6.3)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting ``@dependabot` rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- ``@dependabot` rebase` will rebase this PR
- ``@dependabot` recreate` will recreate this PR, overwriting any edits that have been made to it
- ``@dependabot` merge` will merge this PR after your CI passes on it
- ``@dependabot` squash and merge` will squash and merge this PR after your CI passes on it
- ``@dependabot` cancel merge` will cancel a previously requested merge and block automerging
- ``@dependabot` reopen` will reopen this PR if it is closed
- ``@dependabot` close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- ``@dependabot` ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- ``@dependabot` ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- ``@dependabot` ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)


</details>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.16.0
Development

No branches or pull requests
2 participants
@foresterre @orhun