Add tracing for extra structured debug logging #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foresterre
changed the title
Codecov Report
@@ Coverage Diff @@
## main #129 +/- ##
===========================================
- Coverage 55.92% 44.60% -11.33%
===========================================
Files 13 12 -1
Lines 751 639 -112
===========================================
- Hits 420 285 -135
- Misses 331 354 +23
Continue to review full report at Codecov.
|
|
bors r+ |
|
bors r- |
|
Canceled. |
…sers
Adds logic to initialize tracing. The tracing information is logged to a file, which will be rotated daily.
The events logged using tracing may be more detailed, or simply different from the output we would like to show users.
Tracing may be disabled by running cargo-msrv with the `--no-log` flag. In that case, not even a log file will be created, which may be useful if the log file location (which is currently not configurable) is inaccessible.
For the implementation it is important that we always collect the guards of the non-blocking tracing appender(s), since they will only live as long as the lifetime of the worker guard. If we don't do this, the guards would be dropped after the scope of `if !config.no_tracing() { ... }` ended, and as a result, anything logged in `init_and_run` would not be logged.
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.