Build Forge javadoc and sources in one zip archive #283
Conversation
|
Hum, looks nice, but isn't possible to use these assembly xmls in the dist module ? Why the need for another module ? |
|
Hey George, To your first question: we unpack two sets of dependencies in this pom: one for javadoc and another one for the sources. They have different project dependencies, that is why I decided to have them explicitly in each execution. I didn't get your second question. If it is why do we need the forge-javadoc project, it is because in order to build javadoc and source archive, the packaging type of the project should be jar, while that of dist is pom. I asked you several months ago (wow, how long time it took :-)) and you and Loncoln told me to leave it 'pom'. Cheers, |
|
I think it would be best to add this as another zip file w/classifier to the forge distribution module: Currently we have: forge-distribution-1.2.1.Final.zip I think we should in the same project have: forge-distribution-1.2.1.Final-javadoc.zip |
|
👍 |
|
Hi folks, Actually this commit does exactly this what you requested. I looked at the maven repository and found there the following: forge-distribution-1.2.1-SNAPSHOT.zip Looking at the maven-metadata-local.xml: And if you look at this page: you will see there that the ID of the assembly (in the respective XML) is actually the classifier of the deployed artifact. That's why I think that this commit fulfills the requirements. Cheers, |
|
Wooo! Awesome! Sounds good, then! On Tue, Mar 19, 2013 at 4:44 PM, Ivan St. Ivanov
Lincoln Baxter, III |
|
There is one caveat: the javadoc module is always built, and not when the release profile is invoked. This slows down the build and it's rather unnecessary |
|
That should be easy to fix? On Wed, Mar 20, 2013 at 12:53 PM, George Gastaldi
Lincoln Baxter, III |
No description provided.