Merge pull request #60 from DevFactory/release/multiple-code-improvem…

…ents-fix-1 multiple code improvements: squid:S1118, squid:S1155, squid:S1488
forge · Mar 11, 2016 · b12228d · b12228d
2 parents f3f80ee + 946c4d1
commit b12228d
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/api/src/main/java/org/jboss/forge/roaster/Roaster.java b/api/src/main/java/org/jboss/forge/roaster/Roaster.java
@@ -31,6 +31,8 @@
  */
 public final class Roaster
 {
+   private Roaster() {}
+
    private static List<JavaParser> parsers;
    private static List<FormatterProvider> formatters;
 
@@ -46,7 +48,7 @@ private static List<JavaParser> getParsers()
                parsers.add(p);
             }
          }
-         if (parsers.size() == 0)
+         if (parsers.isEmpty())
          {
             throw new IllegalStateException("No instances of [" + JavaParser.class.getName()
                      + "] were found on the classpath.");
@@ -67,7 +69,7 @@ private static List<FormatterProvider> getFormatters()
                formatters.add(p);
             }
          }
-         if (formatters.size() == 0)
+         if (formatters.isEmpty())
          {
             throw new IllegalStateException("No instances of [" + FormatterProvider.class.getName()
                      + "] were found on the classpath.");
@@ -173,8 +175,7 @@ public static <T extends JavaType<?>> T parse(final Class<T> type, final String
 
          if (type.isInstance(unit.getGoverningType()))
          {
-            final T result = (T) unit.getGoverningType();
-            return result;
+            return (T) unit.getGoverningType();
          }
          else if (unit != null)
          {