Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make default style a bit more subtle #15

Closed
wants to merge 5 commits into from
Closed

make default style a bit more subtle #15

wants to merge 5 commits into from

Conversation

n3dst4
Copy link
Contributor

@n3dst4 n3dst4 commented Oct 12, 2015

This just tweaks the default rulerz stylesheet so that the ruler line is less visually intrusive.

@cmtonkinson cmtonkinson self-assigned this Oct 13, 2015
@cmtonkinson
Copy link
Member

Would you mind sharing a screenshot including the ruler line for comparison? Which syntax theme are you using? Here's mine; you can hardly make out the line (which is just before the c in @text-color-subtle).

subtler-color-screenshot

The original design intent was to have the ruler line match the styles of the line highlight, which is why we chose solid @text-color-subtle. I could be convinced otherwise, but I think your other PR exposes this setting simply enough for most cases.

@n3dst4
Copy link
Contributor Author

n3dst4 commented Oct 13, 2015

Oh interesting. I'm using the default One Dark theme and the ruler is quite stark by default

image

Same using One Light:

image

And here it is with the dashed/faded style:

image

@n3dst4
Copy link
Contributor Author

n3dst4 commented Oct 13, 2015

Perhaps we could compromise? I quite like the dashed effect since it's visually distinct from indent guides (for those that have them) but crank the opacity up to, say, 60%?

@cmtonkinson
Copy link
Member

I think the root problem here is that line-highlight styles have diverged from what they were (and how they're drawn) when I first mimicked them for the ruler. I'll play with that (maybe later today) and push an update to get back to the baseline; then if the ruler is still too strong — or isn't distinguished enough from line guides, et cetera — we can play with it some more.

My preference is to match line-highlight styles exactly, but you aren't the first person to suggest dashing so I'm not staunchly opposed to it. Besides - #14 makes it easier than ever to override the defaults 👍

@n3dst4
Copy link
Contributor Author

n3dst4 commented Oct 13, 2015

had some free time just now so i updated it to the use the syntax variables for the cursor line, but they seem to be not as well defined as the ui variables so it breaks when using an older theme (like Atom Dark and Atom Light).

@n3dst4 n3dst4 closed this Sep 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants